Skip to content

Commit a474872

Browse files
darkfelinegkevinzhengchalmerloweparthea
authored
fix: Use user_verification=preferred for ReAuth WebAuthn challenge (#1798)
Since ReAuth is a second factor credential, it is not necessary to require UV here. This was discussed with ReAuth folks. Also, in practice, downstream clients disregard this because the U2F protocol doesn't expose UV enforcement. --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
1 parent 4b7a1fe commit a474872

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/google-auth/google/oauth2/challenges.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def _obtain_challenge_input_webauthn(self, metadata, webauthn_handler):
225225
challenge=self._unpadded_urlsafe_b64recode(challenge),
226226
timeout_ms=WEBAUTHN_TIMEOUT_MS,
227227
allow_credentials=allow_credentials,
228-
user_verification="required",
228+
user_verification="preferred",
229229
extensions=extension,
230230
)
231231

packages/google-auth/tests/oauth2/test_challenges.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def test_security_key_webauthn():
235235
challenge=challenge._unpadded_urlsafe_b64recode(sk_challenge["challenge"]),
236236
timeout_ms=challenges.WEBAUTHN_TIMEOUT_MS,
237237
allow_credentials=allow_credentials,
238-
user_verification="required",
238+
user_verification="preferred",
239239
extensions=extension,
240240
)
241241

0 commit comments

Comments
 (0)