Skip to content

Commit a43a18c

Browse files
chore(tests): add sleep mocks (#1943)
Some google3 tests were failing due to timeouts. It seems like there were some tests that preformed up to 10 retries, with exponential backoff between each one This PR mocks out sleep, so these tests will complete ~ instantly, rather than > 10 mins --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 0fd4294 commit a43a18c

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

packages/google-auth/tests/compute_engine/test__metadata.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,9 @@ def test_ping_success_custom_root(mock_metrics_header_value):
201201
)
202202

203203

204+
@mock.patch("time.sleep", return_value=None)
204205
@mock.patch("google.auth.metrics.mds_ping", return_value=MDS_PING_METRICS_HEADER_VALUE)
205-
def test_ping_failure_custom_retry(mock_metrics_header_value):
206+
def test_ping_failure_custom_retry(mock_metrics_header_value, _mock_sleep):
206207
request = make_request("")
207208
request.side_effect = exceptions.TransportError()
208209

@@ -450,7 +451,8 @@ def test_get_failure_connection_failed(mock_sleep):
450451
assert request.call_count == 5
451452

452453

453-
def test_get_too_many_requests_retryable_error_failure():
454+
@mock.patch("time.sleep", return_value=None)
455+
def test_get_too_many_requests_retryable_error_failure(_mock_sleep):
454456
request = make_request("too many requests", status=http_client.TOO_MANY_REQUESTS)
455457

456458
with pytest.raises(exceptions.TransportError) as excinfo:
@@ -546,7 +548,8 @@ def test_get_universe_domain_not_found():
546548
assert universe_domain == "googleapis.com"
547549

548550

549-
def test_get_universe_domain_retryable_error_failure():
551+
@mock.patch("time.sleep", return_value=None)
552+
def test_get_universe_domain_retryable_error_failure(_mock_sleep):
550553
# Test that if the universe domain endpoint returns a retryable error
551554
# we should retry.
552555
#

0 commit comments

Comments
 (0)