Skip to content

Commit 7f31d32

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: Add async context manager return types (#85)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent a159f32 commit 7f31d32

4 files changed

Lines changed: 37 additions & 21 deletions

File tree

‎packages/google-cloud-network-services/google/cloud/network_services_v1/services/network_services/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5778,7 +5778,7 @@ async def list_locations(
57785778
# Done; return the response.
57795779
return response
57805780

5781-
async def __aenter__(self):
5781+
async def __aenter__(self) -> "NetworkServicesAsyncClient":
57825782
return self
57835783

57845784
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-network-services/google/cloud/network_services_v1/services/network_services/transports/rest.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5923,7 +5923,7 @@ def __call__(
59235923
request_kwargs = json_format.MessageToDict(request)
59245924
transcoded_request = path_template.transcode(http_options, **request_kwargs)
59255925

5926-
body = json.loads(json.dumps(transcoded_request["body"]))
5926+
body = json.dumps(transcoded_request["body"])
59275927
uri = transcoded_request["uri"]
59285928
method = transcoded_request["method"]
59295929

@@ -6025,7 +6025,7 @@ def __call__(
60256025
request_kwargs = json_format.MessageToDict(request)
60266026
transcoded_request = path_template.transcode(http_options, **request_kwargs)
60276027

6028-
body = json.loads(json.dumps(transcoded_request["body"]))
6028+
body = json.dumps(transcoded_request["body"])
60296029
uri = transcoded_request["uri"]
60306030
method = transcoded_request["method"]
60316031

@@ -6094,7 +6094,7 @@ def __call__(
60946094
request_kwargs = json_format.MessageToDict(request)
60956095
transcoded_request = path_template.transcode(http_options, **request_kwargs)
60966096

6097-
body = json.loads(json.dumps(transcoded_request["body"]))
6097+
body = json.dumps(transcoded_request["body"])
60986098
uri = transcoded_request["uri"]
60996099
method = transcoded_request["method"]
61006100

‎packages/google-cloud-network-services/samples/generated_samples/snippet_metadata_google.cloud.networkservices.v1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-network-services",
11-
"version": "0.5.1"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎packages/google-cloud-network-services/tests/unit/gapic/network_services_v1/test_network_services.py‎

Lines changed: 32 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1199,9 +1199,11 @@ async def test_list_endpoint_policies_async_pages():
11991199
RuntimeError,
12001200
)
12011201
pages = []
1202-
async for page_ in (
1202+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1203+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1204+
async for page_ in ( # pragma: no branch
12031205
await client.list_endpoint_policies(request={})
1204-
).pages: # pragma: no branch
1206+
).pages:
12051207
pages.append(page_)
12061208
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
12071209
assert page_.raw_page.next_page_token == token
@@ -2645,9 +2647,11 @@ async def test_list_gateways_async_pages():
26452647
RuntimeError,
26462648
)
26472649
pages = []
2648-
async for page_ in (
2650+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
2651+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
2652+
async for page_ in ( # pragma: no branch
26492653
await client.list_gateways(request={})
2650-
).pages: # pragma: no branch
2654+
).pages:
26512655
pages.append(page_)
26522656
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
26532657
assert page_.raw_page.next_page_token == token
@@ -4025,9 +4029,11 @@ async def test_list_grpc_routes_async_pages():
40254029
RuntimeError,
40264030
)
40274031
pages = []
4028-
async for page_ in (
4032+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
4033+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
4034+
async for page_ in ( # pragma: no branch
40294035
await client.list_grpc_routes(request={})
4030-
).pages: # pragma: no branch
4036+
).pages:
40314037
pages.append(page_)
40324038
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
40334039
assert page_.raw_page.next_page_token == token
@@ -5447,9 +5453,11 @@ async def test_list_http_routes_async_pages():
54475453
RuntimeError,
54485454
)
54495455
pages = []
5450-
async for page_ in (
5456+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
5457+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
5458+
async for page_ in ( # pragma: no branch
54515459
await client.list_http_routes(request={})
5452-
).pages: # pragma: no branch
5460+
).pages:
54535461
pages.append(page_)
54545462
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
54555463
assert page_.raw_page.next_page_token == token
@@ -6869,9 +6877,11 @@ async def test_list_tcp_routes_async_pages():
68696877
RuntimeError,
68706878
)
68716879
pages = []
6872-
async for page_ in (
6880+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
6881+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
6882+
async for page_ in ( # pragma: no branch
68736883
await client.list_tcp_routes(request={})
6874-
).pages: # pragma: no branch
6884+
).pages:
68756885
pages.append(page_)
68766886
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
68776887
assert page_.raw_page.next_page_token == token
@@ -8241,9 +8251,11 @@ async def test_list_tls_routes_async_pages():
82418251
RuntimeError,
82428252
)
82438253
pages = []
8244-
async for page_ in (
8254+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
8255+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
8256+
async for page_ in ( # pragma: no branch
82458257
await client.list_tls_routes(request={})
8246-
).pages: # pragma: no branch
8258+
).pages:
82478259
pages.append(page_)
82488260
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
82498261
assert page_.raw_page.next_page_token == token
@@ -9636,9 +9648,11 @@ async def test_list_service_bindings_async_pages():
96369648
RuntimeError,
96379649
)
96389650
pages = []
9639-
async for page_ in (
9651+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
9652+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
9653+
async for page_ in ( # pragma: no branch
96409654
await client.list_service_bindings(request={})
9641-
).pages: # pragma: no branch
9655+
).pages:
96429656
pages.append(page_)
96439657
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
96449658
assert page_.raw_page.next_page_token == token
@@ -10813,9 +10827,11 @@ async def test_list_meshes_async_pages():
1081310827
RuntimeError,
1081410828
)
1081510829
pages = []
10816-
async for page_ in (
10830+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
10831+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
10832+
async for page_ in ( # pragma: no branch
1081710833
await client.list_meshes(request={})
10818-
).pages: # pragma: no branch
10834+
).pages:
1081910835
pages.append(page_)
1082010836
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
1082110837
assert page_.raw_page.next_page_token == token

0 commit comments

Comments
 (0)