Skip to content

Commit 6a1ddd1

Browse files
shuoweilshuoweil
authored
feat: Suppress redundant "Completed" status in progress callback (#2419)
This PR refines the visual feedback provided during operation progress. Specifically, it prevents the display of a standalone "✅ Completed." message and green checkmark when no query execution information (like slot time or bytes processed) is available. This often occurs during metadata-only operations or cached results where the "Completed" status is redundant. Fixes #<479944983> 🦕
1 parent 58a69db commit 6a1ddd1

2 files changed

Lines changed: 142 additions & 213 deletions

File tree

‎packages/bigframes/bigframes/formatting_helpers.py‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,12 @@ def progress_callback(
200200
display_id=current_display_id,
201201
)
202202
elif isinstance(event, bigframes.core.events.ExecutionFinished):
203-
display.update_display(
204-
display.HTML(f"✅ Completed. {previous_display_html}"),
205-
display_id=current_display_id,
206-
)
203+
if previous_display_html:
204+
display.update_display(
205+
display.HTML(f"✅ Completed. {previous_display_html}"),
206+
display_id=current_display_id,
207+
)
208+
207209
elif isinstance(event, bigframes.core.events.SessionClosed):
208210
display.update_display(
209211
display.HTML(f"Session {event.session_id} closed."),

0 commit comments

Comments
 (0)