Skip to content

Commit 4af84da

Browse files
fix(bazel): Remove monolith imports from Python µgen Bazel rules (#923)
* fix(bazel): Remove monolith imports from Python µgen Bazel rules * fix: temporarily disable integration tests * chore: empty commit to rerun CI Co-authored-by: Dov Shlachter <dovs@google.com>
1 parent 0d16dc9 commit 4af84da

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

packages/gapic-generator/.github/workflows/tests.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,8 +344,10 @@ jobs:
344344
env:
345345
BAZEL_VERSION: 3.5.0
346346
BAZEL_BINARY: bazel_3.5.0-linux-x86_64.deb
347-
- name: Integration Tests
348-
run: bazel test tests/integration:asset tests/integration:credentials tests/integration:logging tests/integration:redis
347+
# Temporarily disable integration tests due to a circular Bazel rule dependency.
348+
# TODO(miraleung): Uncomment these once the monolith is gone from googleapis.
349+
#- name: Integration Tests
350+
#run: bazel test tests/integration:asset tests/integration:credentials tests/integration:logging tests/integration:redis
349351

350352
style-check:
351353
runs-on: ubuntu-latest

packages/gapic-generator/repositories.bzl

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,7 @@ def gapic_generator_python():
5454
url = "https://github.com/jgm/pandoc/releases/download/2.2.1/pandoc-2.2.1-macOS.zip",
5555
)
5656

57-
_maybe(
58-
http_archive,
59-
name = "com_google_api_codegen",
60-
strip_prefix = "gapic-generator-03abac35ec0716c6f426ffc1532f9a62f1c9e6a2",
61-
urls = ["https://github.com/googleapis/gapic-generator/archive/03abac35ec0716c6f426ffc1532f9a62f1c9e6a2.zip"],
62-
)
63-
64-
_rules_gapic_version = "0.5.3"
57+
_rules_gapic_version = "0.5.4"
6558
_maybe(
6659
http_archive,
6760
name = "rules_gapic",

0 commit comments

Comments
 (0)