Skip to content

Commit 47b23fb

Browse files
committed
Unneeded shim.
1 parent a1903ae commit 47b23fb

1 file changed

Lines changed: 3 additions & 21 deletions

File tree

gcloud/storage/test_connection.py

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -620,23 +620,23 @@ def _makeOne(self, *args, **kw):
620620
return self._getTargetClass()(*args, **kw)
621621

622622
def test_ctor(self):
623-
connection = _Connection()
623+
connection = object()
624624
iterator = self._makeOne(connection)
625625
self.assertTrue(iterator.connection is connection)
626626
self.assertEqual(iterator.path, '/b')
627627
self.assertEqual(iterator.page_number, 0)
628628
self.assertEqual(iterator.next_page_token, None)
629629

630630
def test_get_items_from_response_empty(self):
631-
connection = _Connection()
631+
connection = object()
632632
iterator = self._makeOne(connection)
633633
self.assertEqual(list(iterator.get_items_from_response({})), [])
634634

635635
def test_get_items_from_response_non_empty(self):
636636
from gcloud.storage.bucket import Bucket
637637
KEY = 'key'
638638
response = {'items': [{'name': KEY}]}
639-
connection = _Connection()
639+
connection = object()
640640
iterator = self._makeOne(connection)
641641
buckets = list(iterator.get_items_from_response(response))
642642
self.assertEqual(len(buckets), 1)
@@ -741,24 +741,6 @@ def request(self, **kw):
741741
return self._response, self._content
742742

743743

744-
class _Connection(object):
745-
746-
def __init__(self, *responses):
747-
self._responses = responses
748-
self._requested = []
749-
750-
def api_request(self, **kw):
751-
from gcloud.storage.exceptions import NotFound
752-
self._requested.append(kw)
753-
754-
try:
755-
response, self._responses = self._responses[0], self._responses[1:]
756-
except:
757-
raise NotFound('miss')
758-
else:
759-
return response
760-
761-
762744
class _Credentials(object):
763745

764746
service_account_name = 'testing@example.com'

0 commit comments

Comments
 (0)