Skip to content

Commit 43bafba

Browse files
committed
Restrict requested fields in 'Dataset.exists' API request.
Addresses: #1018 (comment)
1 parent ff626b7 commit 43bafba

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

gcloud/bigquery/dataset.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,8 @@ def exists(self, client=None):
251251
client = self._require_client(client)
252252

253253
try:
254-
client.connection.api_request(method='GET', path=self.path)
254+
client.connection.api_request(method='GET', path=self.path,
255+
query_params={'fields': 'id'})
255256
except NotFound:
256257
return False
257258
else:

gcloud/bigquery/test_dataset.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ def test_exists_miss_w_bound_client(self):
191191
req = conn._requested[0]
192192
self.assertEqual(req['method'], 'GET')
193193
self.assertEqual(req['path'], '/%s' % PATH)
194+
self.assertEqual(req['query_params'], {'fields': 'id'})
194195

195196
def test_exists_hit_w_alternate_client(self):
196197
PATH = 'projects/%s/datasets/%s' % (self.PROJECT, self.DS_NAME)
@@ -207,6 +208,7 @@ def test_exists_hit_w_alternate_client(self):
207208
req = conn2._requested[0]
208209
self.assertEqual(req['method'], 'GET')
209210
self.assertEqual(req['path'], '/%s' % PATH)
211+
self.assertEqual(req['query_params'], {'fields': 'id'})
210212

211213
def test_reload_w_bound_client(self):
212214
PATH = 'projects/%s/datasets/%s' % (self.PROJECT, self.DS_NAME)

0 commit comments

Comments
 (0)