fix: avoid triggering global logging config (#333)

tseaver · web-flow · commit 22a01660cfdd · 2020-12-01T15:52:01.000-08:00
Closes #332
diff --git a/packages/google-cloud-storage/google/cloud/storage/blob.py b/packages/google-cloud-storage/google/cloud/storage/blob.py
@@ -122,6 +122,8 @@
 _DEFAULT_CHUNKSIZE = 104857600  # 1024 * 1024 B * 100 = 100 MB
 _MAX_MULTIPART_SIZE = 8388608  # 8 MB
 
+_logger = logging.getLogger(__name__)
+
 
 class Blob(_PropertyMixin):
     """A wrapper around Cloud Storage's concept of an ``Object``.
@@ -923,7 +925,7 @@ def _do_download(
 
             if checksum:
                 msg = _CHUNKED_DOWNLOAD_CHECKSUM_MESSAGE.format(checksum)
-                logging.info(msg)
+                _logger.info(msg)
 
             if raw_download:
                 klass = RawChunkedDownload
diff --git a/packages/google-cloud-storage/tests/unit/test_blob.py b/packages/google-cloud-storage/tests/unit/test_blob.py
@@ -1115,7 +1115,7 @@ def test__do_download_w_chunks_w_custom_timeout(self):
     def test__do_download_w_chunks_w_checksum(self):
         from google.cloud.storage import blob as blob_module
 
-        with mock.patch("logging.info") as patch:
+        with mock.patch.object(blob_module._logger, "info") as patch:
             self._do_download_helper_w_chunks(
                 w_range=False, raw_download=False, checksum="md5"
             )
@@ -1124,7 +1124,9 @@ def test__do_download_w_chunks_w_checksum(self):
         )
 
     def test__do_download_w_chunks_wo_checksum(self):
-        with mock.patch("logging.info") as patch:
+        from google.cloud.storage import blob as blob_module
+
+        with mock.patch.object(blob_module._logger, "info") as patch:
             self._do_download_helper_w_chunks(
                 w_range=False, raw_download=False, checksum=None
             )

Original file line number	Diff line number	Diff line change
`@@ -1115,7 +1115,7 @@ def test__do_download_w_chunks_w_custom_timeout(self):`
`1115`	`1115`	`def test__do_download_w_chunks_w_checksum(self):`
`1116`	`1116`	`from google.cloud.storage import blob as blob_module`
`1117`	`1117`
`1118`		`- with mock.patch("logging.info") as patch:`
	`1118`	`+ with mock.patch.object(blob_module._logger, "info") as patch:`
`1119`	`1119`	`self._do_download_helper_w_chunks(`
`1120`	`1120`	`w_range=False, raw_download=False, checksum="md5"`
`1121`	`1121`	`)`
`@@ -1124,7 +1124,9 @@ def test__do_download_w_chunks_w_checksum(self):`
`1124`	`1124`	`)`
`1125`	`1125`
`1126`	`1126`	`def test__do_download_w_chunks_wo_checksum(self):`
`1127`		`- with mock.patch("logging.info") as patch:`
	`1127`	`+ from google.cloud.storage import blob as blob_module`
	`1128`	`+`
	`1129`	`+ with mock.patch.object(blob_module._logger, "info") as patch:`
`1128`	`1130`	`self._do_download_helper_w_chunks(`
`1129`	`1131`	`w_range=False, raw_download=False, checksum=None`
`1130`	`1132`	`)`