feat: [google-cloud-securesourcemanager] Add field instance to message .google.cloud.securesourcemanager.v1.ListRepositoriesRequest (#13176)

gcf-owl-bot[bot] · vchudnov-g · web-flow · commit 18b266f70010 · 2024-10-19T10:41:51.000-04:00
- [ ] Regenerate this pull request now. docs: A comment for field `instance` in message `.google.cloud.securesourcemanager.v1.Repository` is changed PiperOrigin-RevId: 686540736 Source-Link: googleapis/googleapis@d3566d5 Source-Link: googleapis/googleapis-gen@a481bc8 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXNlY3VyZXNvdXJjZW1hbmFnZXIvLk93bEJvdC55YW1sIiwiaCI6ImE0ODFiYzg2MjExYmMyNGZkNWE3MmQ1NWNmOGM0MmRkNDY0OWI2MDkifQ== --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
diff --git a/packages/google-cloud-securesourcemanager/google/cloud/securesourcemanager_v1/types/secure_source_manager.py b/packages/google-cloud-securesourcemanager/google/cloud/securesourcemanager_v1/types/secure_source_manager.py
@@ -253,9 +253,11 @@ class Repository(proto.Message):
             Optional. The name of the instance in which the repository
             is hosted, formatted as
             ``projects/{project_number}/locations/{location_id}/instances/{instance_id}``
-            For data plane CreateRepository requests, this field is
-            output only. For control plane CreateRepository requests,
-            this field is used as input.
+            When creating repository via
+            securesourcemanager.googleapis.com (Control Plane API), this
+            field is used as input. When creating repository via
+            \*.sourcemanager.dev (Data Plane API), this field is output
+            only.
         uid (str):
             Output only. Unique identifier of the
             repository.
@@ -833,6 +835,15 @@ class ListRepositoriesRequest(proto.Message):
             server should return.
         filter (str):
             Optional. Filter results.
+        instance (str):
+            Optional. The name of the instance in which the repository
+            is hosted, formatted as
+            ``projects/{project_number}/locations/{location_id}/instances/{instance_id}``.
+            When listing repositories via
+            securesourcemanager.googleapis.com (Control Plane API), this
+            field is required. When listing repositories via
+            \*.sourcemanager.dev (Data Plane API), this field is
+            ignored.
     """
 
     parent: str = proto.Field(
@@ -851,6 +862,10 @@ class ListRepositoriesRequest(proto.Message):
         proto.STRING,
         number=4,
     )
+    instance: str = proto.Field(
+        proto.STRING,
+        number=5,
+    )
 
 
 class ListRepositoriesResponse(proto.Message):
diff --git a/packages/google-cloud-securesourcemanager/scripts/fixup_securesourcemanager_v1_keywords.py b/packages/google-cloud-securesourcemanager/scripts/fixup_securesourcemanager_v1_keywords.py
@@ -47,7 +47,7 @@ class securesourcemanagerCallTransformer(cst.CSTTransformer):
         'get_instance': ('name', ),
         'get_repository': ('name', ),
         'list_instances': ('parent', 'page_size', 'page_token', 'filter', 'order_by', ),
-        'list_repositories': ('parent', 'page_size', 'page_token', 'filter', ),
+        'list_repositories': ('parent', 'page_size', 'page_token', 'filter', 'instance', ),
         'set_iam_policy_repo': ('resource', 'policy', 'update_mask', ),
         'test_iam_permissions_repo': ('resource', 'permissions', ),
     }
diff --git a/packages/google-cloud-securesourcemanager/tests/unit/gapic/securesourcemanager_v1/test_secure_source_manager.py b/packages/google-cloud-securesourcemanager/tests/unit/gapic/securesourcemanager_v1/test_secure_source_manager.py
@@ -2831,6 +2831,7 @@ def test_list_repositories_non_empty_request_with_auto_populated_field():
         parent="parent_value",
         page_token="page_token_value",
         filter="filter_value",
+        instance="instance_value",
     )
 
     # Mock the actual call within the gRPC stub, and fake the request.
@@ -2847,6 +2848,7 @@ def test_list_repositories_non_empty_request_with_auto_populated_field():
             parent="parent_value",
             page_token="page_token_value",
             filter="filter_value",
+            instance="instance_value",
         )
 
 
@@ -6351,6 +6353,7 @@ def test_list_repositories_rest_required_fields(
     assert not set(unset_fields) - set(
         (
             "filter",
+            "instance",
             "page_size",
             "page_token",
         )
@@ -6414,6 +6417,7 @@ def test_list_repositories_rest_unset_required_fields():
         set(
             (
                 "filter",
+                "instance",
                 "pageSize",
                 "pageToken",
             )

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ class securesourcemanagerCallTransformer(cst.CSTTransformer):`
`47`	`47`	`'get_instance': ('name', ),`
`48`	`48`	`'get_repository': ('name', ),`
`49`	`49`	`'list_instances': ('parent', 'page_size', 'page_token', 'filter', 'order_by', ),`
`50`		`- 'list_repositories': ('parent', 'page_size', 'page_token', 'filter', ),`
	`50`	`+ 'list_repositories': ('parent', 'page_size', 'page_token', 'filter', 'instance', ),`
`51`	`51`	`'set_iam_policy_repo': ('resource', 'policy', 'update_mask', ),`
`52`	`52`	`'test_iam_permissions_repo': ('resource', 'permissions', ),`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2831,6 +2831,7 @@ def test_list_repositories_non_empty_request_with_auto_populated_field():`
`2831`	`2831`	`parent="parent_value",`
`2832`	`2832`	`page_token="page_token_value",`
`2833`	`2833`	`filter="filter_value",`
	`2834`	`+ instance="instance_value",`
`2834`	`2835`	`)`
`2835`	`2836`
`2836`	`2837`	`# Mock the actual call within the gRPC stub, and fake the request.`
`@@ -2847,6 +2848,7 @@ def test_list_repositories_non_empty_request_with_auto_populated_field():`
`2847`	`2848`	`parent="parent_value",`
`2848`	`2849`	`page_token="page_token_value",`
`2849`	`2850`	`filter="filter_value",`
	`2851`	`+ instance="instance_value",`
`2850`	`2852`	`)`
`2851`	`2853`
`2852`	`2854`
`@@ -6351,6 +6353,7 @@ def test_list_repositories_rest_required_fields(`
`6351`	`6353`	`assert not set(unset_fields) - set(`
`6352`	`6354`	`(`
`6353`	`6355`	`"filter",`
	`6356`	`+ "instance",`
`6354`	`6357`	`"page_size",`
`6355`	`6358`	`"page_token",`
`6356`	`6359`	`)`
`@@ -6414,6 +6417,7 @@ def test_list_repositories_rest_unset_required_fields():`
`6414`	`6417`	`set(`
`6415`	`6418`	`(`
`6416`	`6419`	`"filter",`
	`6420`	`+ "instance",`
`6417`	`6421`	`"pageSize",`
`6418`	`6422`	`"pageToken",`
`6419`	`6423`	`)`