Skip to content

Commit 188515f

Browse files
committed
Merge pull request #1697 from tseaver/1527-restore_grpc_for_py27_testing
Restore 'grpc' extra for testing on Python 2.7.
2 parents 71d2845 + 4846f86 commit 188515f

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
'pyOpenSSL',
1919
'six',
2020
]
21-
GRPC_EXTRAS = ['grpcio >= 0.13.0']
21+
GRPC_EXTRAS = ['grpcio >= 0.13.1']
2222

2323
setup(
2424
name='gcloud',

tox.ini

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,22 +21,20 @@ covercmd =
2121
--cover-branches \
2222
--nocapture
2323

24-
# Until grpcio 0.13.1 ships, this environment is broken on UCS2 builds.
25-
# See: https://github.com/grpc/grpc/issues/5280 and
26-
# https://github.com/grpc/grpc/pull/5319
27-
#[testenv:py27]
28-
#basepython =
29-
# python2.7
30-
#deps =
31-
# {[testenv]deps}
32-
# grpcio >= 0.13.0
33-
#setenv =
34-
# PYTHONPATH =
24+
[testenv:py27]
25+
basepython =
26+
python2.7
27+
commands =
28+
pip install gcloud[grpc]
29+
nosetests
30+
setenv =
31+
PYTHONPATH =
3532

3633
[testenv:cover]
3734
basepython =
3835
python2.7
3936
commands =
37+
pip install gcloud[grpc]
4038
{[testenv]covercmd} --cover-min-percentage=100
4139
deps =
4240
{[testenv]deps}
@@ -98,12 +96,10 @@ passenv = {[testenv:system-tests]passenv}
9896
basepython =
9997
python2.7
10098
commands =
99+
pip install gcloud[grpc]
101100
python {toxinidir}/system_tests/attempt_system_tests.py
102101
setenv =
103102
PYTHONPATH =
104-
deps =
105-
{[testenv]deps}
106-
grpcio >= 0.13.0
107103
passenv = GOOGLE_* GCLOUD_* TRAVIS* encrypted_*
108104

109105
[testenv:system-tests3]

0 commit comments

Comments
 (0)