You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0699ba6
Browse filesBrowse the repository at this point in the historyBrowse files
fix(pubsub): include request overhead when computing publish batch size overflow (#9911)
* Clarify the description of BatchSettings.max_bytes
* Include overhead in batch overflow calculation
The maximum allowed size for a PublishRequest on the backend is lower
than a mere sum of the byte sizes of individual messages.
This commit adjusts the batch size overflow calculation to account for
this overhead. It also caps the effective maximum BatchSetting.max_size
value to 10_000_000 bytes (the limit on the backend).
(credit also to GitHub @relud for outlining the main idea first in the
issue description)
* Access settings inside Batch in a consistent way.
* Cleanup and refactor a few code snippets
* Raise more specific error if message too large
0 commit comments