Skip to content

build(pubsub): bring over build fixes from the samples PR#8455

Open
feywind wants to merge 2 commits into
mainfrom
feywind-fix-pubsub-build
Open

build(pubsub): bring over build fixes from the samples PR#8455
feywind wants to merge 2 commits into
mainfrom
feywind-fix-pubsub-build

Conversation

@feywind

@feywind feywind commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

A bunch of build fixes were needed in #8091 so I'm moving them over to their own PR.

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jun 8, 2026
@feywind feywind changed the title build: bring over build fixes from the samples PR build(pubsub): bring over build fixes from the samples PR Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces type annotations for the logs object across several files using a new Loggers type (defined as Record<string, LoggingFunction>) to resolve TypeScript declaration build errors, and adds a type cast in pubsub.ts. The reviewer feedback points out that typing logs as a generic Record causes a loss of type safety for the specific keys of the logs objects. To fix the build errors while preserving full type safety, the reviewer suggests importing loggingUtils from google-gax directly in each file instead of using the generic Loggers annotation.

Comment thread handwritten/pubsub/src/logs.ts
Comment thread handwritten/pubsub/src/lease-manager.ts Outdated
Comment thread handwritten/pubsub/src/message-queues.ts Outdated
Comment thread handwritten/pubsub/src/message-stream.ts Outdated
Comment thread handwritten/pubsub/src/publisher/message-queues.ts Outdated
Comment thread handwritten/pubsub/src/subscriber.ts Outdated
Comment thread handwritten/pubsub/src/subscriber.ts Outdated
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant