build(pubsub): bring over build fixes from the samples PR#8455
Open
feywind wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces type annotations for the logs object across several files using a new Loggers type (defined as Record<string, LoggingFunction>) to resolve TypeScript declaration build errors, and adds a type cast in pubsub.ts. The reviewer feedback points out that typing logs as a generic Record causes a loss of type safety for the specific keys of the logs objects. To fix the build errors while preserving full type safety, the reviewer suggests importing loggingUtils from google-gax directly in each file instead of using the generic Loggers annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of build fixes were needed in #8091 so I'm moving them over to their own PR.