Skip to content

Commit ca4f4ab

Browse files
committed
fix: update workflows to respect matrix node version
1 parent faf79df commit ca4f4ab

2 files changed

Lines changed: 12 additions & 4 deletions

File tree

.github/workflows/presubmit.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,18 @@ jobs:
66
runs-on: ubuntu-latest
77
strategy:
88
matrix:
9-
node: [18, 20, 22]
9+
node-version: ['18.x', '20.x', '22.x']
1010
steps:
1111
- uses: actions/checkout@v6
1212
with:
1313
fetch-depth: 300
14+
- name: Use Node.js ${{ matrix.node-version }}
15+
uses: actions/setup-node@v6
16+
with:
17+
node-version: ${{ matrix.node-version }}
1418
- uses: pnpm/action-setup@v4
1519
with:
16-
version: ^7.0.0
20+
version: ^10.0.0
1721
- run: node --version
1822
- run: ci/run_conditional_tests.sh
1923
name: Run unit tests

.github/workflows/windows-presubmit.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,18 @@ jobs:
66
runs-on: windows-latest
77
strategy:
88
matrix:
9-
node: [18, 20, 22]
9+
node-version: ['18.x', '20.x', '22.x']
1010
steps:
1111
- uses: actions/checkout@v6
1212
with:
1313
fetch-depth: 300
14+
- name: Use Node.js ${{ matrix.node-version }}
15+
uses: actions/setup-node@v6
16+
with:
17+
node-version: ${{ matrix.node-version }}
1418
- uses: pnpm/action-setup@v4
1519
with:
16-
version: ^7.0.0
20+
version: ^10.0.0
1721
- run: node --version
1822
- run: bash ci/run_conditional_tests.sh
1923
name: Run windows unit tests

0 commit comments

Comments
 (0)