fix(spanner): enable afe_connectivity_error_count metric (#7964)

surbhigarg92 · web-flow · commit 4d597690ad90 · 2026-04-07T07:04:27.000Z
enable AFE connectivity metric. This was disabled as part of https://togithub.com/googleapis/nodejs-spanner/pull/2417
diff --git a/handwritten/spanner/src/metrics/interceptor.ts b/handwritten/spanner/src/metrics/interceptor.ts
@@ -75,9 +75,7 @@ export const MetricInterceptor = (options, nextCall) => {
           if (metricsTracer?.afeLatency) {
             metricsTracer?.recordAfeLatency(status.code);
           } else {
-            // Disable afe_connectivity_error_count metric as AFE header is disabled in backend
-            // currently.
-            // metricsTracer?.recordAfeConnectivityErrorCount(status.code);
+            metricsTracer?.recordAfeConnectivityErrorCount(status.code);
           }
         },
       };
diff --git a/handwritten/spanner/test/metrics/interceptor.ts b/handwritten/spanner/test/metrics/interceptor.ts
@@ -197,7 +197,7 @@ describe('MetricInterceptor', () => {
       );
     });
 
-    it.skip('AFE Metrics - Connectivity Error Count', () => {
+    it('AFE Metrics - Connectivity Error Count', () => {
       const interceptingCall = MetricInterceptor(mockOptions, mockNextCall);
       interceptingCall.start(testMetadata, mockListener);
 
diff --git a/handwritten/spanner/test/metrics/metrics.ts b/handwritten/spanner/test/metrics/metrics.ts
@@ -458,6 +458,10 @@ describe('Test metrics with mock server', () => {
         resourceMetrics,
         METRIC_NAME_GFE_CONNECTIVITY_ERROR_COUNT,
       );
+      const afeConnectivityErrorCountData = getMetricData(
+        resourceMetrics,
+        METRIC_NAME_AFE_CONNECTIVITY_ERROR_COUNT,
+      );
 
       // Verify GFE AFE latency doesn't exist
       assert.ok(!hasMetricData(resourceMetrics, METRIC_NAME_GFE_LATENCIES));
@@ -483,6 +487,10 @@ describe('Test metrics with mock server', () => {
           getAggregatedValue(connectivityErrorCountData, attributes),
           1,
         );
+        assert.strictEqual(
+          getAggregatedValue(afeConnectivityErrorCountData, attributes),
+          1,
+        );
       });
     });
 
