chore: adapt owlbot.py and conformance tests for monorepo, set throw-deprecation to false to not crash test due to deprecated dep (punycode), exclude .mocharc and readme from owlbot

GautamSharda · GautamSharda · commit 3d079d180dfb · 2026-03-25T19:29:54.000Z
diff --git a/.github/workflows/conformance.yaml b/.github/workflows/conformance.yaml
@@ -17,11 +17,18 @@ on:
   push:
     branches:
     - main
+    paths:
+    - 'handwritten/bigtable/**'
   pull_request:
+    paths:
+    - 'handwritten/bigtable/**'
 name: conformance
 jobs:
   conformance:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: handwritten/bigtable
     strategy:
       matrix:
         node: [ 18, 20 ]
@@ -31,7 +38,7 @@ jobs:
       with:
         repository: googleapis/cloud-bigtable-clients-test
         ref: main
-        path: cloud-bigtable-clients-test
+        path: handwritten/bigtable/cloud-bigtable-clients-test
     - uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node }}
diff --git a/.github/workflows/mandatory-conformance.yaml b/.github/workflows/mandatory-conformance.yaml
@@ -17,11 +17,18 @@ on:
   push:
     branches:
     - main
+    paths:
+    - 'handwritten/bigtable/**'
   pull_request:
+    paths:
+    - 'handwritten/bigtable/**'
 name: mandatory-conformance
 jobs:
   mandatory-conformance:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: handwritten/bigtable
     strategy:
       matrix:
         node: [ 18, 20 ]
@@ -31,7 +38,7 @@ jobs:
       with:
         repository: googleapis/cloud-bigtable-clients-test
         ref: v0.0.3
-        path: cloud-bigtable-clients-test
+        path: handwritten/bigtable/cloud-bigtable-clients-test
     - uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node }}
@@ -41,4 +48,4 @@ jobs:
     - run: chmod +x .kokoro/mandatory-conformance.sh
     - run: npm install
     - run: go version
-    - run: .kokoro/mandatory-conformance.sh
+    - run: .kokoro/mandatory-conformance.sh
diff --git a/core/common/.mocharc.js b/core/common/.mocharc.js
@@ -13,7 +13,7 @@
 // limitations under the License.
 const config = {
   "enable-source-maps": true,
-  "throw-deprecation": true,
+  "throw-deprecation": false,
   "timeout": 10000,
   "recursive": true
 }
diff --git a/handwritten/bigtable/.mocharc.js b/handwritten/bigtable/.mocharc.js
@@ -13,7 +13,7 @@
 // limitations under the License.
 const config = {
   "enable-source-maps": true,
-  "throw-deprecation": true,
+  "throw-deprecation": false,
   "timeout": 10000,
   "recursive": true
 }
diff --git a/handwritten/bigtable/owlbot.py b/handwritten/bigtable/owlbot.py
@@ -23,7 +23,7 @@
 
 logging.basicConfig(level=logging.DEBUG)
 
-staging = Path("owl-bot-staging")
+staging = Path("owl-bot-staging/bigtable")
 
 if staging.is_dir():
     versions = ['v2']
@@ -65,14 +65,14 @@
             '.kokoro/test.sh',
         ] + list(admin_files)
         logging.info(f"excluding files for non-admin: {excludes}")
-        s.copy([library], excludes = excludes)
+        s.copy([library], destination="handwritten/bigtable", excludes = excludes)
 
     # Copy the admin library pieces and knit them in.
     # Don't override system-test for admin/v2, just keep the v2 version.
     for version in versions:
         admin_version = f"admin/{version}"
         library = src_paths[admin_version]
-        inProtoPath = f"protos/google/bigtable/{admin_version}"
+        inProtoPath = f"handwritten/bigtable/protos/google/bigtable/{admin_version}"
         protos = library / inProtoPath
         classes = library / 'src' / version
         samples = library / 'samples' / 'generated'
@@ -145,14 +145,14 @@
         os.system(f"mkdir -p {inProtoPath}")
         s.copy([protos / '*'], destination=inProtoPath)
         os.system(f"mkdir -p src/{admin_version}")
-        s.copy([classes / '*'], destination=f"src/{admin_version}")
+        s.copy([classes / '*'], destination=f"handwritten/bigtable/src/{admin_version}")
         os.system(f"mkdir -p samples/generated/{admin_version}")
-        s.copy([samples / 'v2' / '*admin*'], destination=f"samples/generated/{admin_version}")
+        s.copy([samples / 'v2' / '*admin*'], destination=f"handwritten/bigtable/samples/generated/{admin_version}")
         os.system(f"mkdir -p test/{admin_version}")
-        s.copy([tests / '*admin*.ts'], destination=f"test/{admin_version}")
+        s.copy([tests / '*admin*.ts'], destination=f"handwritten/bigtable/test/{admin_version}")
 
     # Replace the client name for generated system-test.
-    system_test_files=['system-test/fixtures/sample/src/index.ts','system-test/fixtures/sample/src/index.js']
+    system_test_files=['handwritten/bigtable/system-test/fixtures/sample/src/index.ts','handwritten/bigtable/system-test/fixtures/sample/src/index.js']
     for file in system_test_files:
         s.replace(file, 'BigtableClient', 'Bigtable')
         s.replace(file, 'client.close', '// client.close') # this does not work with the manual layer
@@ -162,16 +162,19 @@
     shutil.rmtree(staging)
 
 common_templates = gcp.CommonTemplates()
-templates = common_templates.node_library(
+templates = common_templates.node_mono_repo_library(
+  relative_dir="handwritten/bigtable", 
   source_location='build/src'
 )
-s.copy(templates,excludes=[
+s.copy(templates,destination="handwritten/bigtable", excludes=[
     '.github/auto-approve.yml',
     '.github/sync-repo-settings.yaml',
     '.github/workflows/ci.yaml',
     '.kokoro/samples-test.sh',  # get to green
     '.kokoro/system-test.sh',
     '.kokoro/test.sh',
+    '.mocharc.js',
+    'README.md'
 ])
 
-node.postprocess_gapic_library_hermetic()
+node.postprocess_gapic_library_hermetic(relative_dir="handwritten/bigtable")

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`// limitations under the License.`
`14`	`14`	`const config = {`
`15`	`15`	`"enable-source-maps": true,`
`16`		`- "throw-deprecation": true,`
	`16`	`+ "throw-deprecation": false,`
`17`	`17`	`"timeout": 10000,`
`18`	`18`	`"recursive": true`
`19`	`19`	`}`