test(storage): limit integration test forks to 1 and other integration test fixes#13400
Open
Dhriti07 wants to merge 6 commits into
Open
test(storage): limit integration test forks to 1 and other integration test fixes#13400Dhriti07 wants to merge 6 commits into
Dhriti07 wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the maven-failsafe-plugin in the pom.xml file for google-cloud-storage to set the fork count to 1, enable fork reuse, and set the testbench.keepAlive system property to true. There are no review comments, and I have no feedback to provide.
added 5 commits
June 9, 2026 09:12
…ame-executor deadlocks
… container after execution
ShreyasSinha
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the migration to the mono-repo parent pom defined fork-count for maven failsafe plugin as 1C which runs 1 JVM fork per CPU Core. This could be the reason for multiple issues across various tests due to the parallelism such as thread starvation, CPU throttling, and timeout flakiness on multi-core CI VMs. This PR overrides the parent POM configuration to limit the integration test fork count to 1 in google-cloud-storage.
This Pr also contains an attempted fix for vm timeout errors and hangs in the integration test. Rationale: Previously the GCS client and the FakeServer run in the same JVM and share the same Netty thread pool. When the client makes a blocking call and waits for the server, it occupies the shared threads. This could have starved the mock server preventing it from processing the request.
Note: The tests will take ~ 5-10 longer to run than previous configuration.