Skip to content

chore(java-iam-policy): update name pretty#13393

Merged
zhumin8 merged 4 commits into
googleapis:mainfrom
zhumin8:fix-iam-policy-name
Jun 8, 2026
Merged

chore(java-iam-policy): update name pretty#13393
zhumin8 merged 4 commits into
googleapis:mainfrom
zhumin8:fix-iam-policy-name

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented Jun 8, 2026

Bring in change made in #13378 for iam-policy name to config and generate.
run these commands locally:

V=$(go run github.com/googleapis/librarian/cmd/librarian@latest config get version)
go run github.com/googleapis/librarian/cmd/librarian@${V} generate iam-policy

Fixes googleapis/librarian#6336

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pretty name and documentation references for the IAM Policy service from "IAM" to "Google Cloud IAM Policy" across configuration files and the Java client README. The review feedback correctly identifies a couple of instances in the README where the name update resulted in a duplicate "Google" prefix (e.g., "Google Google Cloud"), and provides suggestions to clean those up.

Comment thread java-iam-policy/README.md Outdated
Comment thread java-iam-policy/README.md Outdated
@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Jun 8, 2026

@jinseopkim0 is the name change related to the fix in the script fix in #13378, or was it only cosmetic? After the templated README generation, it now creates this "Google Google Cloud IAM Policy Client for Java" name. Can we remove "Google" and use "Cloud IAM Policy" instead?

@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Jun 8, 2026

per chat discussion, updated name.

@zhumin8 zhumin8 marked this pull request as ready for review June 8, 2026 18:41
@zhumin8 zhumin8 requested review from a team as code owners June 8, 2026 18:41
@zhumin8 zhumin8 requested a review from jinseopkim0 June 8, 2026 18:43
@zhumin8 zhumin8 merged commit e1e4059 into googleapis:main Jun 8, 2026
174 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinseopkim0 jinseopkim0 jinseopkim0 approved these changes

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

java: resolve generation diff

3 participants

@zhumin8 @jinseopkim0 @JoeWang1127