chore: avoid GitHub Search API rate-limit during README generation#13378
chore: avoid GitHub Search API rate-limit during README generation#13378jinseopkim0 wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the repository links in the README to point to the google-cloud-java monorepo and simplifies the README generation script by replacing dynamic GitHub API repository fetching with a static list of external repositories. The review feedback highlights two key issues: a potential runtime error in the generator script due to unfiltered None values from client_for_module, and a duplicate 'IAM' entry name in the generated README table that should be distinguished.
…licate IAM naming
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to link several Google Cloud Java libraries to their monorepo paths, adds several new APIs, and refactors generate-readme.py to use a static list of external repositories instead of dynamically querying the GitHub API. The review feedback correctly points out that glob() returns files in an arbitrary order, which can cause non-deterministic sorting of libraries with the same display name in the generated README.md, and suggests sorting LIBRARIES_IN_MONOREPO to ensure stable output.
|
/gemini review |
1 similar comment
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the README generation script (generate-readme.py) by replacing dynamic GitHub API repository fetching with a static list of external repositories, and refines the sorting logic for libraries. It also updates the README.md with new and relocated Google Cloud Java libraries, and updates the pretty name in java-iam-policy metadata. A review comment suggests a defensive programming improvement in the sorting logic to prevent a potential TypeError if artifact_id is None.
There was a problem hiding this comment.
Code Review
This pull request updates the README.md with corrected repository links and several new APIs, and simplifies the README generation script (generate-readme.py) by replacing dynamic GitHub API repository fetching with a static list of external repositories. Additionally, it refines the sorting logic in the script. Feedback on the changes suggests handling potential None values for artifact_id during sorting to prevent a TypeError.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the README generation script (generate-readme.py) to use a static list of external repositories instead of dynamically querying the GitHub API, and refines the sorting logic to sort by artifact ID when titles are identical. Consequently, the README.md has been regenerated to reflect updated monorepo links, add several new APIs, and correct metadata names (such as updating the IAM Policy pretty name). There are no review comments provided, so I have no feedback to address.
b/520464446