test(logging): make ITTailLogsTest robust against backend tailing delay#13366
Draft
lqiu96 wants to merge 3 commits into
Draft
test(logging): make ITTailLogsTest robust against backend tailing delay#13366lqiu96 wants to merge 3 commits into
lqiu96 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the integration test testTailLogEntries in ITTailLogsTest by removing the @Ignore annotation and reducing the timeout. It replaces a static sleep with a background thread that writes log entries periodically until they are intercepted. A critical issue was identified in the log name comparison: log.getLogName().equals(LOG_ID) will always evaluate to false because getLogName() returns a fully qualified path while LOG_ID is a simple identifier. This would cause the test to hang and time out. The reviewer suggested using endsWith(LOG_ID) instead.
Resolves PR 13366 feedback by comparing fully qualified log names returned by the streaming tailing RPC using .endsWith(LOG_ID).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes @ignore and transitions from a static 10s delay single write to 1-second periodic writes during real-time tailing session startup.
Fixes: #11908