chore(java-shared-config): migrate java-shared-config into monorepo and integrate parent POM#13339
chore(java-shared-config): migrate java-shared-config into monorepo and integrate parent POM#13339jinseopkim0 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates the java-shared-config module into the monorepo, setting up its build configurations, Dockerfiles, and POM files, and updating parent references and dependency versions across other modules. The review feedback identifies a duplicate team reference in .github/CODEOWNERS and a portability issue with the mktemp command in generation/apply_versions.sh on macOS.
| /java-bigtable/ @googleapis/bigtable-team @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team | ||
| /java-firestore/ @googleapis/firestore-team @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team | ||
| /librarian.yaml @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team | ||
| /java-shared-config/ @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-java-team |
There was a problem hiding this comment.
There is a duplicate team reference @googleapis/cloud-sdk-java-team on this line. It should be @googleapis/cloud-sdk-librarian-team instead, matching the pattern of the other entries in this file.
/java-shared-config/ @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team
|
|
||
|
|
||
| SED_OPTIONS="" | ||
| SED_SCRIPT_FILE=$(mktemp) |
There was a problem hiding this comment.
Using mktemp without any arguments or templates is not portable and will fail on macOS (BSD mktemp), which requires a template argument. To ensure portability for developers running this script locally on macOS, use a fallback to mktemp -t.
| SED_SCRIPT_FILE=$(mktemp) | |
| SED_SCRIPT_FILE=$(mktemp 2>/dev/null || mktemp -t apply_versions.XXXXXX) |
|
|
This PR migrates the java-shared-config repository into the google-cloud-java monorepo, resolves a latent argument-limit bug in apply_versions.sh, and updates the foundational parent POM in sdk-platform-java-config to inherit from the new local module rather than external dependencies on Maven Central. Closes b/477663125.