-
Notifications
You must be signed in to change notification settings - Fork 1.1k
BlobWriteChannel CRC32C and MD5 hash mismatch error #267
Copy link
Copy link
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
The following code:
causes an error:
If a stale
BlobInfoobject is passed tostorage.writer(blobInfo)instead:No error occurs.
It seems to me that if a "complete"
StorageObjectis passed toDefaultStorageRpc.openthen itsmd5Hashandcrc32cfields are used to request the upload id (see this line). At the end of the upload if that data do not match with the uploaded one the whole upload fails.Do you think this is a desirable default behavior?
I think it is not, I would rather add some options to
storage.writer(...)to allow users to explicitly choose to checkmd5Hashandcrc32cif they have already computed them and put them into theBlobInfoobject (i.e. if they know what they're doing).Thoughts?