Skip to content

Commit f4b576c

Browse files
committed
Add constants for updated values in MetricInfoTest
1 parent 9e342a6 commit f4b576c

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

gcloud-java-logging/src/test/java/com/google/cloud/logging/MetricInfoTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ public class MetricInfoTest {
2626
private static final String NAME = "name";
2727
private static final String FILTER = "logName=projects/my-projectid/logs/syslog";
2828
private static final String DESCRIPTION = "description";
29+
private static final String NEW_NAME = "newName";
30+
private static final String NEW_FILTER = "logName=projects/my-projectid/logs/newSyslog";
31+
private static final String NEW_DESCRIPTION = "newDescription";
2932
private static final MetricInfo METRIC_INFO = MetricInfo.builder(NAME, FILTER)
3033
.description(DESCRIPTION)
3134
.build();
@@ -49,13 +52,13 @@ public void testBuilder() {
4952
public void testToBuilder() {
5053
compareMetricInfo(METRIC_INFO, METRIC_INFO.toBuilder().build());
5154
MetricInfo metricInfo = METRIC_INFO.toBuilder()
52-
.name("newName")
53-
.description("newDescription")
54-
.filter("logName=projects/my-projectid/logs/syslog")
55+
.name(NEW_NAME)
56+
.description(NEW_DESCRIPTION)
57+
.filter(NEW_FILTER)
5558
.build();
56-
assertEquals("newName", metricInfo.name());
57-
assertEquals("logName=projects/my-projectid/logs/syslog", metricInfo.filter());
58-
assertEquals("newDescription", metricInfo.description());
59+
assertEquals(NEW_NAME, metricInfo.name());
60+
assertEquals(NEW_FILTER, metricInfo.filter());
61+
assertEquals(NEW_DESCRIPTION, metricInfo.description());
5962
metricInfo = metricInfo.toBuilder()
6063
.name(NAME)
6164
.description(DESCRIPTION)

0 commit comments

Comments
 (0)