Close channel and fix typo (#1036)

jean-philippe-martin · mziccard · commit ed440e95d223 · 2016-06-01T08:12:24.000+02:00
diff --git a/gcloud-java-examples/src/main/java/com/google/cloud/examples/nio/CountBytes.java b/gcloud-java-examples/src/main/java/com/google/cloud/examples/nio/CountBytes.java
@@ -71,25 +71,26 @@ private static void countFile(String fname) {
       ByteBuffer buf = ByteBuffer.allocate(bufSize);
       System.out.println("Reading the whole file...");
       Stopwatch sw = Stopwatch.createStarted();
-      SeekableByteChannel chan = Files.newByteChannel(path);
-      long total = 0;
-      int readCalls = 0;
-      MessageDigest md = MessageDigest.getInstance("MD5");
-      while (chan.read(buf) > 0) {
-        readCalls++;
-        md.update(buf.array(), 0, buf.position());
-        total += buf.position();
-        buf.flip();
-      }
-      readCalls++; // We must count the last call
-      long elapsed = sw.elapsed(TimeUnit.SECONDS);
-      System.out.println("Read all " + total + " bytes in " + elapsed + "s. " +
-          "(" + readCalls +" calls to chan.read)");
-      String hex = String.valueOf(BaseEncoding.base16().encode(md.digest()));
-      System.out.println("The MD5 is: 0x" + hex);
-      if (total != size) {
-        System.out.println("Wait, this doesn't match! We saw " + total + " bytes, " +
-            "yet the file size is listed at " + size + " bytes.");
+      try (SeekableByteChannel chan = Files.newByteChannel(path)) {
+        long total = 0;
+        int readCalls = 0;
+        MessageDigest md = MessageDigest.getInstance("MD5");
+        while (chan.read(buf) > 0) {
+          readCalls++;
+          md.update(buf.array(), 0, buf.position());
+          total += buf.position();
+          buf.flip();
+        }
+        readCalls++; // We must count the last call
+        long elapsed = sw.elapsed(TimeUnit.SECONDS);
+        System.out.println("Read all " + total + " bytes in " + elapsed + "s. " +
+            "(" + readCalls +" calls to chan.read)");
+        String hex = String.valueOf(BaseEncoding.base16().encode(md.digest()));
+        System.out.println("The MD5 is: 0x" + hex);
+        if (total != size) {
+          System.out.println("Wait, this doesn't match! We saw " + total + " bytes, " +
+              "yet the file size is listed at " + size + " bytes.");
+        }
       }
     } catch (Exception ex) {
       System.out.println(fname + ": " + ex.toString());
diff --git a/gcloud-java-examples/src/main/java/com/google/cloud/examples/nio/ParallelCountBytes.java b/gcloud-java-examples/src/main/java/com/google/cloud/examples/nio/ParallelCountBytes.java
@@ -79,7 +79,7 @@ public WorkUnit call() throws IOException {
         return this;
       }
       chan.position(pos);
-      // read until buffer it is full, or EOF
+      // read until buffer is full, or EOF
       while (chan.read(buf) > 0) {};
       return this;
     }

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public WorkUnit call() throws IOException {`
`79`	`79`	`return this;`
`80`	`80`	`}`
`81`	`81`	`chan.position(pos);`
`82`		`- // read until buffer it is full, or EOF`
	`82`	`+ // read until buffer is full, or EOF`
`83`	`83`	`while (chan.read(buf) > 0) {};`
`84`	`84`	`return this;`
`85`	`85`	`}`