Skip to content

Commit ebe8c77

Browse files
committed
Move MonitoredResourceDescriptor to core module
1 parent c8be379 commit ebe8c77

File tree

3 files changed

+24
-19
lines changed

3 files changed

+24
-19
lines changed

gcloud-java-core/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,5 +108,10 @@
108108
<artifactId>gax</artifactId>
109109
<version>0.0.13</version>
110110
</dependency>
111+
<dependency>
112+
<groupId>com.google.api.grpc</groupId>
113+
<artifactId>grpc-core-proto</artifactId>
114+
<version>0.0.4</version>
115+
</dependency>
111116
</dependencies>
112117
</project>

gcloud-java-logging/src/main/java/com/google/cloud/logging/MonitoredResourceDescriptor.java renamed to gcloud-java-core/src/main/java/com/google/cloud/MonitoredResourceDescriptor.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.cloud.logging;
17+
package com.google.cloud;
1818

1919
import static com.google.common.base.Preconditions.checkNotNull;
2020

@@ -29,23 +29,23 @@
2929
import java.util.Objects;
3030

3131
/**
32-
* This class describes the schema of Cloud Logging monitored resources. Monitored resource
33-
* descriptors contain a type name and a set of labels. For example, the monitored resource
34-
* descriptor for Google Compute Engine VM instances has a type of {@code gce_instance} and
35-
* specifies the use of the labels {@code instance_id} and {@code zone} to identify particular VM
36-
* instances.
32+
* This class describes the schema of Cloud monitored resources. Monitored resource descriptors
33+
* contain a type name and a set of labels. For example, the monitored resource descriptor for
34+
* Google Compute Engine VM instances has a type of {@code gce_instance} and specifies the use of
35+
* the labels {@code instance_id} and {@code zone} to identify particular VM instances.
3736
*/
3837
public class MonitoredResourceDescriptor implements Serializable {
3938

4039
private static final long serialVersionUID = -3702077512777687441L;
41-
static final Function<com.google.api.MonitoredResourceDescriptor, MonitoredResourceDescriptor>
42-
FROM_PB_FUNCTION =
43-
new Function<com.google.api.MonitoredResourceDescriptor, MonitoredResourceDescriptor>() {
44-
@Override
45-
public MonitoredResourceDescriptor apply(com.google.api.MonitoredResourceDescriptor pb) {
46-
return fromPb(pb);
47-
}
48-
};
40+
public static final Function<com.google.api.MonitoredResourceDescriptor,
41+
MonitoredResourceDescriptor> FROM_PB_FUNCTION =
42+
new Function<com.google.api.MonitoredResourceDescriptor, MonitoredResourceDescriptor>() {
43+
@Override
44+
public MonitoredResourceDescriptor apply(
45+
com.google.api.MonitoredResourceDescriptor pb) {
46+
return fromPb(pb);
47+
}
48+
};
4949

5050
private final String type;
5151
private final String name;
@@ -306,7 +306,7 @@ public String toString() {
306306
.toString();
307307
}
308308

309-
com.google.api.MonitoredResourceDescriptor toPb() {
309+
public com.google.api.MonitoredResourceDescriptor toPb() {
310310
com.google.api.MonitoredResourceDescriptor.Builder builder =
311311
com.google.api.MonitoredResourceDescriptor.newBuilder()
312312
.setType(type)
@@ -327,7 +327,7 @@ static Builder builder(String type) {
327327
return new Builder(type);
328328
}
329329

330-
static MonitoredResourceDescriptor fromPb(
330+
public static MonitoredResourceDescriptor fromPb(
331331
com.google.api.MonitoredResourceDescriptor descriptorPb) {
332332
Builder builder = builder(descriptorPb.getType());
333333
if (descriptorPb.getName() != null && !descriptorPb.getName().equals("")) {

gcloud-java-logging/src/test/java/com/google/cloud/logging/MonitoredResourceDescriptorTest.java renamed to gcloud-java-core/src/test/java/com/google/cloud/MonitoredResourceDescriptorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.cloud.logging;
17+
package com.google.cloud;
1818

1919
import static org.junit.Assert.assertEquals;
2020
import static org.junit.Assert.assertNull;
2121

22-
import com.google.cloud.logging.MonitoredResourceDescriptor.LabelDescriptor;
23-
import com.google.cloud.logging.MonitoredResourceDescriptor.LabelDescriptor.ValueType;
22+
import com.google.cloud.MonitoredResourceDescriptor.LabelDescriptor;
23+
import com.google.cloud.MonitoredResourceDescriptor.LabelDescriptor.ValueType;
2424
import com.google.common.collect.ImmutableList;
2525

2626
import org.junit.Test;

0 commit comments

Comments
 (0)