Using the executor in ApiFutures.catching (#73)

sduskis · web-flow · commit bd24e0ab36bb · 2019-03-08T10:28:21.000-05:00
An executor is passed in, but never used.
diff --git a/sdk-platform-java/api-common-java/src/main/java/com/google/api/core/ApiFutures.java b/sdk-platform-java/api-common-java/src/main/java/com/google/api/core/ApiFutures.java
@@ -100,7 +100,7 @@ public static <V, X extends Throwable> ApiFuture<V> catching(
             listenableFutureForApiFuture(input),
             exceptionType,
             new GaxFunctionToGuavaFunction<X, V>(callback),
-            directExecutor());
+            executor);
     return new ListenableFutureToApiFuture<V>(catchingFuture);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public static <V, X extends Throwable> ApiFuture<V> catching(`
`100`	`100`	`listenableFutureForApiFuture(input),`
`101`	`101`	`exceptionType,`
`102`	`102`	`new GaxFunctionToGuavaFunction<X, V>(callback),`
`103`		`- directExecutor());`
	`103`	`+ executor);`
`104`	`104`	`return new ListenableFutureToApiFuture<V>(catchingFuture);`
`105`	`105`	`}`
`106`	`106`