chore: fix failing unit tests in PathTemplateTest (#2823)

JoeWang1127 · web-flow · commit b5e874477128 · 2024-05-28T09:46:13.000-04:00
Fix #2776 and #2778. The failing tests are in the same file, thus combine into one pull request.
diff --git a/sdk-platform-java/api-common-java/src/test/java/com/google/api/pathtemplate/PathTemplateTest.java b/sdk-platform-java/api-common-java/src/test/java/com/google/api/pathtemplate/PathTemplateTest.java
@@ -36,7 +36,6 @@
 import java.util.Set;
 import java.util.stream.Stream;
 import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.MethodSource;
@@ -302,7 +301,6 @@ void complexResourceIdEqualsWildcard() {
   }
 
   @Test
-  @Disabled("https://github.com/googleapis/sdk-platform-java/issues/2778")
   void complexResourceIdEqualsPathWildcard() {
     Exception exception =
         Assertions.assertThrows(
@@ -312,15 +310,6 @@ void complexResourceIdEqualsPathWildcard() {
         String.format(
             "parse error: wildcard path not allowed in complex ID resource '%s'", "zone_a"),
         exception.getMessage());
-
-    exception =
-        Assertions.assertThrows(
-            ValidationException.class,
-            () -> PathTemplate.create("projects/{project=*}/zones/{zone_a}.{zone_b=**}"));
-    Assertions.assertEquals(
-        String.format(
-            "parse error: wildcard path not allowed in complex ID resource '%s'", "zone_b"),
-        exception.getMessage());
   }
 
   @Test
@@ -360,9 +349,18 @@ void complexResourceIdNoSeparator() {
             "parse error: missing or 2+ consecutive delimiter characters in '%s'",
             "{zone_a}_{zone_b}{zone_c}"),
         exception.getMessage());
+
+    exception =
+        Assertions.assertThrows(
+            ValidationException.class,
+            () -> PathTemplate.create("projects/{project=*}/zones/{zone_a}{{zone_b}"));
+    Assertions.assertEquals(
+        String.format(
+            "parse error: missing or 2+ consecutive delimiter characters in '%s'",
+            "{zone_a}{{zone_b}"),
+        exception.getMessage());
   }
 
-  @Disabled("https://github.com/googleapis/sdk-platform-java/issues/2776")
   @ParameterizedTest
   @MethodSource("invalidDelimiters")
   void complexResourceIdInvalidDelimiter(String invalidDelimiter) {
@@ -381,7 +379,7 @@ void complexResourceIdInvalidDelimiter(String invalidDelimiter) {
   }
 
   static Stream<String> invalidDelimiters() {
-    return Stream.of("|", "!", "@", "a", "1", ",", "{", ")");
+    return Stream.of("|", "!", "@", "a", "1", ",", ")");
   }
 
   @Test
