Remove second replace method

Ajay Kannan · Ajay Kannan · commit 951be77470c3 · 2016-01-29T09:58:10.000-08:00
diff --git a/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/Project.java b/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/Project.java
@@ -196,21 +196,6 @@ public void undelete() {
     resourceManager.undelete(projectId());
   }
 
-  /**
-   * Replaces the attributes of the project with the attributes from the given {@code ProjectInfo}.
-   *
-   * <p>The caller must have modify permissions for this project.
-   *
-   * @see <a
-   * href="https://cloud.google.com/resource-manager/reference/rest/v1beta1/projects/update">Cloud
-   * Resource Manager update</a>
-   * @return the Project representing the new project metadata
-   * @throws ResourceManagerException upon failure
-   */
-  public Project replace(ProjectInfo projectInfo) {
-    return resourceManager.replace(checkNotNull(projectInfo));
-  }
-
   /**
    * Replaces the attributes of the project with the attributes of this project.
    *
diff --git a/gcloud-java-resourcemanager/src/test/java/com/google/gcloud/resourcemanager/ProjectTest.java b/gcloud-java-resourcemanager/src/test/java/com/google/gcloud/resourcemanager/ProjectTest.java
@@ -168,42 +168,32 @@ public void testUndelete() {
   }
 
   @Test
-  public void testReplaceWithProjectInfo() {
+  public void testReplace() {
     initializeExpectedProject(2);
-    ProjectInfo newInfo = PROJECT_INFO.toBuilder().addLabel("k3", "v3").build();
-    Project expectedProject =
-        new Project(serviceMockReturnsOptions, new ProjectInfo.BuilderImpl(newInfo));
-    expect(resourceManager.options()).andReturn(mockOptions);
-    expect(resourceManager.replace(newInfo)).andReturn(expectedProject);
-    replay(resourceManager);
-    initializeProject();
-    Project newProject = project.replace(newInfo);
-    assertEquals(expectedProject, newProject);
-  }
-
-  @Test
-  public void testReplaceWithoutProjectInfo() {
-    initializeExpectedProject(2);
-    ProjectInfo newInfo = PROJECT_INFO.toBuilder().addLabel("k3", "v3").build();
-    Project expectedProject =
-        new Project(serviceMockReturnsOptions, new ProjectInfo.BuilderImpl(newInfo));
-    expect(resourceManager.options()).andReturn(mockOptions);
-    expect(resourceManager.replace(anyObject(Project.class))).andReturn(expectedProject);
+    Project expectedReplacedProject = expectedProject.toBuilder().addLabel("k3", "v3").build();
+    expect(resourceManager.options()).andReturn(mockOptions).times(2);
+    expect(resourceManager.replace(anyObject(Project.class))).andReturn(expectedReplacedProject);
     replay(resourceManager);
     initializeProject();
-    Project newProject = project.replace(newInfo);
-    assertEquals(expectedProject, newProject);
+    Project newProject =
+        new Project(resourceManager, new ProjectInfo.BuilderImpl(expectedReplacedProject));
+    Project actualReplacedProject = newProject.replace();
+    compareProjectInfos(expectedReplacedProject, actualReplacedProject);
   }
 
   private void compareProjects(Project expected, Project value) {
     assertEquals(expected, value);
+    compareProjectInfos(expected, value);
+    assertEquals(expected.resourceManager().options(), value.resourceManager().options());
+  }
+
+  private void compareProjectInfos(ProjectInfo expected, ProjectInfo value) {
     assertEquals(expected.projectId(), value.projectId());
     assertEquals(expected.name(), value.name());
     assertEquals(expected.labels(), value.labels());
     assertEquals(expected.projectNumber(), value.projectNumber());
     assertEquals(expected.createTimeMillis(), value.createTimeMillis());
     assertEquals(expected.state(), value.state());
     assertEquals(expected.parent(), value.parent());
-    assertEquals(expected.resourceManager().options(), value.resourceManager().options());
   }
 }
