Add options(namespace) method to LocalDatastoreHelper

mziccard · mziccard · commit 91bd4603ba85 · 2016-04-18T11:28:09.000+02:00
diff --git a/gcloud-java-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java b/gcloud-java-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java
@@ -75,6 +75,9 @@ public DatastoreOptions build() {
       return new DatastoreOptions(this);
     }
 
+    /**
+     * Sets the default namespace to be used by the datastore service.
+     */
     public Builder namespace(String namespace) {
       this.namespace = validateNamespace(namespace);
       return this;
@@ -112,6 +115,9 @@ protected DatastoreRpcFactory defaultRpcFactory() {
     return DefaultDatastoreRpcFactory.INSTANCE;
   }
 
+  /**
+   * Returns the default namespace to be used by the datastore service.
+   */
   public String namespace() {
     return namespace;
   }
diff --git a/gcloud-java-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java b/gcloud-java-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java
@@ -569,6 +569,20 @@ public DatastoreOptions options() {
         .build();
   }
 
+  /**
+   * Returns a {@link DatastoreOptions} instance that sets the host to use the Datastore emulator on
+   * localhost. The default namespace is set to {@code namespace}.
+   */
+  public DatastoreOptions options(String namespace) {
+    return DatastoreOptions.builder()
+        .projectId(projectId)
+        .host("localhost:" + Integer.toString(port))
+        .authCredentials(AuthCredentials.noAuth())
+        .retryParams(RetryParams.noRetries())
+        .namespace(namespace)
+        .build();
+  }
+
   /**
    * Returns the project ID associated with this local Datastore emulator.
    */
diff --git a/gcloud-java-datastore/src/test/java/com/google/cloud/datastore/testing/LocalDatastoreHelperTest.java b/gcloud-java-datastore/src/test/java/com/google/cloud/datastore/testing/LocalDatastoreHelperTest.java
@@ -16,6 +16,7 @@
 
 package com.google.cloud.datastore.testing;
 
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
 
@@ -31,6 +32,7 @@ public class LocalDatastoreHelperTest {
 
   private static final double TOLERANCE = 0.00001;
   private static final String PROJECT_ID_PREFIX = "test-project-";
+  private static final String NAMESPACE = "namespace";
 
   @Test
   public void testCreate() {
@@ -49,5 +51,10 @@ public void testOptions() {
     assertTrue(options.projectId().startsWith(PROJECT_ID_PREFIX));
     assertTrue(options.host().startsWith("localhost:"));
     assertSame(AuthCredentials.noAuth(), options.authCredentials());
+    options = helper.options(NAMESPACE);
+    assertTrue(options.projectId().startsWith(PROJECT_ID_PREFIX));
+    assertTrue(options.host().startsWith("localhost:"));
+    assertSame(AuthCredentials.noAuth(), options.authCredentials());
+    assertEquals(NAMESPACE, options.namespace());
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,9 @@ public DatastoreOptions build() {`
`75`	`75`	`return new DatastoreOptions(this);`
`76`	`76`	`}`
`77`	`77`
	`78`	`+ /**`
	`79`	`+ * Sets the default namespace to be used by the datastore service.`
	`80`	`+ */`
`78`	`81`	`public Builder namespace(String namespace) {`
`79`	`82`	`this.namespace = validateNamespace(namespace);`
`80`	`83`	`return this;`
`@@ -112,6 +115,9 @@ protected DatastoreRpcFactory defaultRpcFactory() {`
`112`	`115`	`return DefaultDatastoreRpcFactory.INSTANCE;`
`113`	`116`	`}`
`114`	`117`
	`118`	`+ /**`
	`119`	`+ * Returns the default namespace to be used by the datastore service.`
	`120`	`+ */`
`115`	`121`	`public String namespace() {`
`116`	`122`	`return namespace;`
`117`	`123`	`}`