chore: new-client.py to fail with message when a module exists (#9256)

suztomo · web-flow · commit 3d9341a8ba86 · 2023-03-20T15:00:22.000Z
Fixes https://togithub.com/googleapis/google-cloud-java/issues/9244 ``` suztomo@suztomo2:~/google-cloud-java$ python3.9 generation/new_client/new-client.py generate \ --api_shortname=datacatalog \ --proto-path=google/cloud/datacatalog \ --name-pretty="Data Catalog" \ --product-docs="https://cloud.google.com/data-catalog" \ --api-description="DataCatalog is a centralized and unified data catalog service for all your Cloud resources, where users and systems can discover data, explore and curate its semantics, understand how to act on it, and help govern its usage." /usr/local/google/home/suztomo/google-cloud-java/generation/new_client Couldn't create the module because the module /usr/local/google/home/suztomo/google-cloud-java/java-datacatalog already exists. In Java client library generation, a new API version of an existing module does not require new-client.py invocation. See go/yoshi-java-new-client#adding-a-new-service-version-by-owlbot. ```
diff --git a/generation/new_client/new-client.py b/generation/new_client/new-client.py
@@ -213,7 +213,14 @@ def generate(
 
     # Initialize workdir
     workdir = Path(f"{sys.path[0]}/../../java-{output_name}").resolve()
-    subprocess.run(["rm", "-fr", workdir])
+    if os.path.isdir(workdir):
+      sys.exit(
+          "Couldn't create the module because "
+          f"the module {workdir} already exists. In Java client library "
+          "generation, a new API version of an existing module does not "
+          "require new-client.py invocation. "
+          "See go/yoshi-java-new-client#adding-a-new-service-version-by-owlbot."
+      )
     print(f"Creating a new module {workdir}")
     os.makedirs(workdir, exist_ok=False)
     # write .repo-metadata.json file
