remove todos that suggest depending on appengine artifact to get projectId and namespace

Ajay Kannan · Ajay Kannan · commit 38253d9bab3e · 2015-10-28T10:38:48.000-07:00
diff --git a/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java b/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java
@@ -411,8 +411,6 @@ private static boolean isWindows() {
   }
 
   protected static String getAppEngineProjectId() {
-    // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:
-    // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0
     try {
       Class<?> factoryClass =
           Class.forName("com.google.appengine.api.appidentity.AppIdentityServiceFactory");
diff --git a/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java b/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java
@@ -172,8 +172,6 @@ public String namespace() {
   }
 
   private static String defaultNamespace() {
-    // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:
-    // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0
     try {
       Class<?> clazz = Class.forName("com.google.appengine.api.NamespaceManager");
       Method method = clazz.getMethod("get");
diff --git a/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java b/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java
@@ -459,7 +459,6 @@ public void testRunStructuredQuery() {
     assertEquals("Dan", entity.getString("name"));
     assertEquals(2, entity.properties().size());
     assertFalse(results4.hasNext());
-    // TODO(ozarov): construct a test to verify nextQuery/pagination
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -411,8 +411,6 @@ private static boolean isWindows() {`
`411`	`411`	`}`
`412`	`412`
`413`	`413`	`protected static String getAppEngineProjectId() {`
`414`		`- // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:`
`415`		`- // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0`
`416`	`414`	`try {`
`417`	`415`	`Class<?> factoryClass =`
`418`	`416`	`Class.forName("com.google.appengine.api.appidentity.AppIdentityServiceFactory");`
Original file line number	Diff line number	Diff line change
`@@ -172,8 +172,6 @@ public String namespace() {`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`private static String defaultNamespace() {`
`175`		`- // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:`
`176`		`- // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0`
`177`	`175`	`try {`
`178`	`176`	`Class<?> clazz = Class.forName("com.google.appengine.api.NamespaceManager");`
`179`	`177`	`Method method = clazz.getMethod("get");`
Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,6 @@ public void testRunStructuredQuery() {`
`459`	`459`	`assertEquals("Dan", entity.getString("name"));`
`460`	`460`	`assertEquals(2, entity.properties().size());`
`461`	`461`	`assertFalse(results4.hasNext());`
`462`		`- // TODO(ozarov): construct a test to verify nextQuery/pagination`
`463`	`462`	`}`
`464`	`463`
`465`	`464`	`@Test`