Javadocs: adding links to external types (#1600)

garrettjonesgoogle · web-flow · commit 240e9f190a82 · 2017-02-08T14:31:24.000-08:00
diff --git a/google-cloud-core/pom.xml b/google-cloud-core/pom.xml
@@ -111,7 +111,7 @@
     <dependency>
       <groupId>com.google.api</groupId>
       <artifactId>gax</artifactId>
-      <version>0.0.28</version>
+      <version>${gax.version}</version>
       <exclusions>
         <exclusion>
           <groupId>io.grpc</groupId>
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
@@ -127,7 +127,7 @@ private Subscriber(Builder builder) throws IOException {
   /**
    * Constructs a new {@link Builder}.
    *
-   * <p>Once {@link #build()} is called a gRPC stub will be created for use of the {@link
+   * <p>Once {@link Builder#build()} is called a gRPC stub will be created for use of the {@link
    * Subscriber}.
    *
    * @param subscription Cloud Pub/Sub subscription to bind the subscriber to
@@ -143,7 +143,7 @@ public SubscriptionName getSubscriptionName() {
     return impl.subscriptionName;
   }
 
-  /** Acknowledgement expiration padding. See {@link Builder.setAckExpirationPadding}. */
+  /** Acknowledgement expiration padding. See {@link Builder#setAckExpirationPadding}. */
   public Duration getAckExpirationPadding() {
     return impl.ackExpirationPadding;
   }
diff --git a/pom.xml b/pom.xml
@@ -92,6 +92,8 @@
     <github.global.server>github</github.global.server>
     <google.auth.version>0.6.0</google.auth.version>
     <grpc.version>1.0.3</grpc.version>
+    <gax.version>0.0.28</gax.version>
+    <generatedProto.version>0.1.5</generatedProto.version>
     <core.version>0.8.4-alpha-SNAPSHOT</core.version>
     <beta.version>0.8.4-beta-SNAPSHOT</beta.version>
     <storage.version>${beta.version}</storage.version>
@@ -425,7 +427,18 @@
                   </group>
                 </groups>
                 <links>
+                  <link>https://developers.google.com/protocol-buffers/docs/reference/java/</link>
                   <link>http://google.github.io/google-auth-library-java/releases/${google.auth.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/gax-java/${gax.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-iam-v1/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-error-reporting-v1beta1/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-language-v1/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-logging-v2/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-monitoring-v3/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-pubsub-v1/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-speech-v1beta1/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-trace-v1/${generatedProto.version}/apidocs/</link>
+                  <link>http://googleapis.github.io/googleapis/java/grpc-google-cloud-vision-v1/${generatedProto.version}/apidocs/</link>
                 </links>
               </configuration>
             </plugin>

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ private Subscriber(Builder builder) throws IOException {`
`127`	`127`	`/**`
`128`	`128`	`* Constructs a new {@link Builder}.`
`129`	`129`	`*`
`130`		`- * <p>Once {@link #build()} is called a gRPC stub will be created for use of the {@link`
	`130`	`+ * <p>Once {@link Builder#build()} is called a gRPC stub will be created for use of the {@link`
`131`	`131`	`* Subscriber}.`
`132`	`132`	`*`
`133`	`133`	`* @param subscription Cloud Pub/Sub subscription to bind the subscriber to`
`@@ -143,7 +143,7 @@ public SubscriptionName getSubscriptionName() {`
`143`	`143`	`return impl.subscriptionName;`
`144`	`144`	`}`
`145`	`145`
`146`		`- /** Acknowledgement expiration padding. See {@link Builder.setAckExpirationPadding}. */`
	`146`	`+ /** Acknowledgement expiration padding. See {@link Builder#setAckExpirationPadding}. */`
`147`	`147`	`public Duration getAckExpirationPadding() {`
`148`	`148`	`return impl.ackExpirationPadding;`
`149`	`149`	`}`