Log gcd.sh errors instead of printing to stderr

Ajay Kannan · Ajay Kannan · commit 235da5aade45 · 2015-10-13T20:11:11.000-07:00
diff --git a/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/testing/LocalGcdHelper.java b/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/testing/LocalGcdHelper.java
@@ -214,18 +214,17 @@ public void run() {
       try {
         boolean readerDone = false;
         boolean errorReaderDone = false;
+        String currentLog = null;
         while (!readerDone || !errorReaderDone) {
           if (!readerDone && reader.ready()) {
-            readerDone = reader.readLine() != null;
+            readerDone = reader.readLine() == null;
           }
           if (!errorReaderDone && errorReader.ready()) {
             String errorOutput = errorReader.readLine();
             if (errorOutput == null) {
               errorReaderDone = true;
             } else {
-              if (errorOutput.startsWith("SEVERE")) {
-                System.err.println(errorOutput);
-              }
+              currentLog = processLog(errorOutput, currentLog);
             }
           }
         }
@@ -234,6 +233,27 @@ public void run() {
       }
     }
 
+    private static boolean isNewGcdLog(String line) {
+      return line.contains("com.google.apphosting.client.serviceapp.BaseApiServlet")
+          && !line.trim().startsWith("at ");
+    }
+
+    private static String processLog(String currentLine, String currentLog) {
+      if (isNewGcdLog(currentLine)) {
+        if (currentLog != null) {
+          log.info(currentLog.trim());
+        }
+        return "GCD ";
+      } else if (currentLine.startsWith("SEVERE: ")) {
+        return null; // Don't show duplicate error messages from gcd.sh
+      } else if (currentLog != null && currentLine.startsWith("INFO: ")) {
+        return currentLog + currentLine.substring("INFO: ".length()) + "\n";
+      } else if (currentLog != null && !currentLine.trim().startsWith("at ")) {
+        return currentLog + currentLine + "\n";
+      }
+      return currentLog;
+    }
+
     public static ProcessStreamReader start(
         Process process, String blockUntil, boolean blockOnErrorStream) throws IOException {
       ProcessStreamReader thread = new ProcessStreamReader(process, blockUntil, blockOnErrorStream);
