Skip to content

Commit 16ccbb6

Browse files
committed
set_parent_pom.sh to exclude java-shared-dependencies
The java-shared-dependencies should not depend on google-cloud-jar parent because it imports java-shared-dependencies.
1 parent 993b1e3 commit 16ccbb6

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

generation/set_parent_pom.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ function replaceParent {
2424
# Then, apply the values as the parent pom of each module
2525
for module in $(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort --dictionary-order | xargs dirname); do
2626
# example value of module is "./java-accessapproval"
27-
if [[ "${module}" = *gapic-libraries-bom ]] || [[ "${module}" = *google-cloud-jar-parent ]] || [[ "${module}" = *google-cloud-pom-parent ]]; then
27+
if [[ "${module}" = *gapic-libraries-bom ]] || \
28+
[[ "${module}" = *google-cloud-jar-parent ]] || \
29+
[[ "${module}" = *google-cloud-pom-parent ]] || \
30+
[[ "${module}" = *java-shared-dependencies ]]; then
2831
continue
2932
fi
3033
echo "Processing module $module"

java-core/google-cloud-core-bom/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<artifactId>google-cloud-core-bom</artifactId>
66
<version>2.9.5-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
77
<packaging>pom</packaging>
8+
89
<parent>
910
<groupId>com.google.cloud</groupId>
1011
<artifactId>google-cloud-pom-parent</artifactId>

0 commit comments

Comments
 (0)