fix(spanner): fix data-race caused by TrackSessionHandle (#10321)

egonelbre · harshachinta · web-flow · commit 23c5fffd06bc · 2024-06-12T15:49:15.000+05:30
Fixes #10320 Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>
diff --git a/spanner/session.go b/spanner/session.go
@@ -926,10 +926,10 @@ func (p *sessionPool) newSessionHandle(s *session) (sh *sessionHandle) {
 	if p.TrackSessionHandles || p.ActionOnInactiveTransaction == Warn || p.ActionOnInactiveTransaction == WarnAndClose || p.ActionOnInactiveTransaction == Close {
 		p.mu.Lock()
 		sh.trackedSessionHandle = p.trackedSessionHandles.PushBack(sh)
-		p.mu.Unlock()
 		if p.TrackSessionHandles {
 			sh.stack = debug.Stack()
 		}
+		p.mu.Unlock()
 	}
 	return sh
 }

Original file line number	Diff line number	Diff line change
`@@ -926,10 +926,10 @@ func (p sessionPool) newSessionHandle(s session) (sh *sessionHandle) {`
`926`	`926`	`if p.TrackSessionHandles \|\| p.ActionOnInactiveTransaction == Warn \|\| p.ActionOnInactiveTransaction == WarnAndClose \|\| p.ActionOnInactiveTransaction == Close {`
`927`	`927`	`p.mu.Lock()`
`928`	`928`	`sh.trackedSessionHandle = p.trackedSessionHandles.PushBack(sh)`
`929`		`- p.mu.Unlock()`
`930`	`929`	`if p.TrackSessionHandles {`
`931`	`930`	`sh.stack = debug.Stack()`
`932`	`931`	`}`
	`932`	`+ p.mu.Unlock()`
`933`	`933`	`}`
`934`	`934`	`return sh`
`935`	`935`	`}`