Skip to content

Commit f8a9d41

Browse files
authored
cleanup: remove references to google-cloud-cpp-* (#4329)
I was just going to remove the vcpkg references, but I found many other references in the documentation and comments that needed fixing too.
1 parent 02bc8fa commit f8a9d41

12 files changed

Lines changed: 21 additions & 23 deletions

File tree

ci/generate-markdown/generate-spanner-readme.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Please note that the Google Cloud C++ client libraries do **not** follow
4949
5050
[doxygen-link]: https://googleapis.dev/cpp/google-cloud-spanner/latest/
5151
[cloud-spanner-docs]: https://cloud.google.com/spanner/docs/
52-
[source-link]: https://github.com/googleapis/google-cloud-cpp-spanner/tree/master/google/cloud/spanner
52+
[source-link]: https://github.com/googleapis/google-cloud-cpp/tree/master/google/cloud/spanner
5353
5454
## Quickstart
5555

ci/kokoro/docker/build-in-docker-quickstart-cmake.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ fi
5858
./bootstrap-vcpkg.sh
5959
./vcpkg remove --outdated --recurse
6060
./vcpkg install google-cloud-cpp
61-
./vcpkg install google-cloud-cpp-spanner
6261
)
6362
# Use the new installed/ directory to create the cache.
6463
rm -fr "${HOME}/vcpkg-quickstart-cache"

ci/kokoro/windows/build.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,15 @@ if (($BuildName -eq "cmake") -or ($BuildName -eq "cmake-debug")) {
8888
$env:VCPKG_TRIPLET = "x64-windows-static"
8989
$env:BUILD_CACHE = "gs://cloud-cpp-kokoro-results/build-cache/google-cloud-cpp/master/vcpkg/Debug/x64-windows-static/quickstart.zip"
9090
$DependencyScript = "build-cmake-dependencies.ps1"
91-
$DependencyScriptArgs=@("cmake-out/vcpkg-quickstart", "google-cloud-cpp", "google-cloud-cpp-spanner")
91+
$DependencyScriptArgs=@("cmake-out/vcpkg-quickstart", "google-cloud-cpp")
9292
$BuildScript = "build-quickstart-cmake.ps1"
9393
} elseif ($BuildName -eq "quickstart-cmake-dll") {
9494
$env:CONFIG = "Debug"
9595
$env:GENERATOR = "Ninja"
9696
$env:VCPKG_TRIPLET = "x64-windows"
9797
$env:BUILD_CACHE = "gs://cloud-cpp-kokoro-results/build-cache/google-cloud-cpp/master/vcpkg/Debug/x64-windows/quickstart.zip"
9898
$DependencyScript = "build-cmake-dependencies.ps1"
99-
$DependencyScriptArgs=@("cmake-out/vcpkg-quickstart", "google-cloud-cpp", "google-cloud-cpp-spanner")
99+
$DependencyScriptArgs=@("cmake-out/vcpkg-quickstart", "google-cloud-cpp")
100100
$BuildScript = "build-quickstart-cmake.ps1"
101101
}
102102

doc/setup-development-environment.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ installing `google-cloud-cpp` itself:
187187

188188
```console
189189
> vcpkg.exe install google-cloud-cpp:x64-windows-static
190-
> vcpkg.exe install --recurse google-cloud-cpp-common[test]:x64-windows-static
191190
> vcpkg.exe integrate install
192191
```
193192

google/cloud/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ load(":google_cloud_cpp_grpc_utils.bzl", "google_cloud_cpp_grpc_utils_hdrs", "go
6969
cc_library(
7070
name = "google_cloud_cpp_grpc_utils",
7171
srcs = google_cloud_cpp_grpc_utils_srcs,
72-
# TODO(googleapis/google-cloud-cpp-common##171) - remove the filtering
72+
# TODO(googleapis/google-cloud-cpp-common#171) - remove the filtering
7373
# comprehension.
7474
hdrs = [
7575
header

google/cloud/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ notice. These include `google/cloud/internal/`, and
3030
* Detailed header comments in our [public `.h`][source-link] files
3131

3232
[doxygen-link]: https://googleapis.dev/cpp/google-cloud-common/latest/
33-
[source-link]: https://github.com/googleapis/google-cloud-cpp-common/tree/master/google/cloud
33+
[source-link]: https://github.com/googleapis/google-cloud-cpp/tree/master/google/cloud
3434

3535
## Contributing changes
3636

google/cloud/spanner/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Please note that the Google Cloud C++ client libraries do **not** follow
2525

2626
[doxygen-link]: https://googleapis.dev/cpp/google-cloud-spanner/latest/
2727
[cloud-spanner-docs]: https://cloud.google.com/spanner/docs/
28-
[source-link]: https://github.com/googleapis/google-cloud-cpp-spanner/tree/master/google/cloud/spanner
28+
[source-link]: https://github.com/googleapis/google-cloud-cpp/tree/master/google/cloud/spanner
2929

3030
## Quickstart
3131

google/cloud/spanner/benchmarks/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ You must compile both the library and its dependencies with optimization, using
4040
CMake this is:
4141

4242
```bash
43-
git clone https://github.com/googleapis/google-cloud-cpp-spanner.git
44-
cd google-cloud-cpp-spanner
43+
git clone https://github.com/googleapis/google-cloud-cpp.git
44+
cd google-cloud-cpp
4545
cmake -Hsuper -Bcmake-out/si -DCMAKE_BUILD_TYPE=Release \
4646
-DGOOGLE_CLOUD_CPP_EXTERNAL_PREFIX=$HOME/local-spanner
4747
cmake --build cmake-out/si --target project-dependencies

google/cloud/spanner/doc/spanner-main.dox

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ includes detailed instructions on how to compile the library for use in your
3535
application. You can fetch the source from [GitHub][github-link] as normal:
3636

3737
@code{.sh}
38-
git clone https://github.com/googleapis/google-cloud-cpp-spanner.git
39-
cd google-cloud-cpp-spanner/google/cloud/spanner/quickstart
38+
git clone https://github.com/googleapis/google-cloud-cpp.git
39+
cd google-cloud-cpp/google/cloud/spanner/quickstart
4040
@endcode
4141

4242
@par Example: Hello World
@@ -157,8 +157,8 @@ period between retries.
157157
[concepts-link]: https://cloud.google.com/storage/docs/concepts 'GCS Concepts'
158158
[authentication-quickstart]: https://cloud.google.com/docs/authentication/getting-started 'Authentication Getting Started'
159159
[gcloud-quickstart]: https://cloud.google.com/sdk/docs/quickstarts
160-
[github-link]: https://github.com/googleapis/google-cloud-cpp-spanner 'GitHub Repository'
161-
[quickstart-link]: https://github.com/googleapis/google-cloud-cpp-spanner/blob/master/google/cloud/spanner/quickstart
162-
[status-or-header]: https://github.com/googleapis/google-cloud-cpp-common/blob/master/google/cloud/status_or.h
160+
[github-link]: https://github.com/googleapis/google-cloud-cpp 'GitHub Repository'
161+
[quickstart-link]: https://github.com/googleapis/google-cloud-cpp/blob/master/google/cloud/spanner/quickstart
162+
[status-or-header]: https://github.com/googleapis/google-cloud-cpp/blob/master/google/cloud/status_or.h
163163

164164
*/

google/cloud/spanner/quickstart/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# License for the specific language governing permissions and limitations under
1313
# the License.
1414

15-
# This CMake file shows how to use `google-cloud-cpp-spanner` from a larger
15+
# This CMake file shows how to use the Cloud Spanner C++ client from a larger
1616
# CMake project.
1717

1818
cmake_minimum_required(VERSION 3.5)

0 commit comments

Comments
 (0)