impl(docfx): introduce yaml-cpp dependency (#10964)

coryan · web-flow · commit f87f771b070a · 2023-02-28T08:37:04.000-05:00
I will need to generate YAML files. These look simple until you start
reading about how to quote string literals.
diff --git a/bazel/google_cloud_cpp_deps.bzl b/bazel/google_cloud_cpp_deps.bzl
@@ -229,3 +229,14 @@ def google_cloud_cpp_deps(name = None):
         strip_prefix = "pugixml-1.13",
         build_file = Label("//bazel:pugixml.BUILD"),
     )
+
+    maybe(
+        http_archive,
+        name = "com_github_jbeder_yaml_cpp",
+        urls = [
+            "https://storage.googleapis.com/cloud-cpp-community-archive/com_github_jbeder_yaml_cpp/yaml-cpp-0.7.0.tar.gz",
+            "https://github.com/jbeder/yaml-cpp/archive/yaml-cpp-0.7.0.tar.gz",
+        ],
+        sha256 = "43e6a9fcb146ad871515f0d0873947e5d497a1c9c60c58cb102a97b47208b7c3",
+        strip_prefix = "yaml-cpp-yaml-cpp-0.7.0",
+    )
diff --git a/ci/cloudbuild/dockerfiles/fedora-37-cmake.Dockerfile b/ci/cloudbuild/dockerfiles/fedora-37-cmake.Dockerfile
@@ -40,7 +40,7 @@ RUN dnf makecache && dnf install -y "dnf-command(debuginfo-install)"
 RUN dnf makecache && dnf debuginfo-install -y libstdc++
 
 # This is used by the docfx tool.
-RUN dnf makecache && dnf install -y pugixml-devel
+RUN dnf makecache && dnf install -y pugixml-devel yaml-cpp-devel
 
 # Sets root's password to the empty string to enable users to get a root shell
 # inside the container with `su -` and no password. Sudo would not work because
diff --git a/docfx/BUILD.bazel b/docfx/BUILD.bazel
@@ -30,6 +30,7 @@ cc_library(
         "//conditions:default": [],
     }),
     deps = [
+        "@com_github_jbeder_yaml_cpp//:yaml-cpp",
         "@com_github_zeux_pugixml//:pugixml",
     ],
 )
diff --git a/docfx/CMakeLists.txt b/docfx/CMakeLists.txt
@@ -24,6 +24,7 @@ if (NOT GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
 endif ()
 
 find_package(pugixml CONFIG REQUIRED)
+find_package(yaml-cpp CONFIG REQUIRED)
 
 include(EnableWerror)
 
@@ -34,7 +35,7 @@ add_library(
 google_cloud_cpp_add_common_options(docfx)
 target_include_directories(docfx PUBLIC "${PROJECT_SOURCE_DIR}")
 target_compile_features(docfx PUBLIC cxx_std_17)
-target_link_libraries(docfx PUBLIC pugixml::pugixml)
+target_link_libraries(docfx PUBLIC pugixml::pugixml yaml-cpp)
 
 # To avoid maintaining the list of files for the library, export them to a .bzl
 # file.
diff --git a/vcpkg.json b/vcpkg.json
@@ -31,6 +31,10 @@
     {
       "name": "pugixml",
       "$description": "Only used for the docfx feature"
+    },
+    {
+      "name": "yaml-cpp",
+      "$description": "Only used for the docfx feature"
     }
   ]
 }

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ cc_library(`
`30`	`30`	`"//conditions:default": [],`
`31`	`31`	`}),`
`32`	`32`	`deps = [`
	`33`	`+ "@com_github_jbeder_yaml_cpp//:yaml-cpp",`
`33`	`34`	`"@com_github_zeux_pugixml//:pugixml",`
`34`	`35`	`],`
`35`	`36`	`)`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,10 @@`
`31`	`31`	`{`
`32`	`32`	`"name": "pugixml",`
`33`	`33`	`"$description": "Only used for the docfx feature"`
	`34`	`+ },`
	`35`	`+ {`
	`36`	`+ "name": "yaml-cpp",`
	`37`	`+ "$description": "Only used for the docfx feature"`
`34`	`38`	`}`
`35`	`39`	`]`
`36`	`40`	`}`