@@ -36,17 +36,17 @@ For a generated library there are 3 critical checks:
3636In addition, we (the Cloud C++ team) require a simple ` quickstart.cc ` for each
3737library. This program is typically created when the library is generated.
3838
39- ### ` BUILD.bazel `
39+ ### ` cmake/GoogleCloudCppFeatures.cmake `
4040
41- Update the top-level ` BUILD.bazel ` file. Move the library from
42- ` EXPERIMENTAL_LIBRARIES ` to ` TRANSITION_LIBRARIES ` . Do this first as it helps
43- automate the following steps.
41+ Update ` cmake/GoogleCloudCppFeatures.cmake ` . Move the library from
42+ ` GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES ` to
43+ ` GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES ` . Do this first as it helps automate the
44+ following steps.
4445
4546``` shell
46- mapfile -t ga < <( bazel --batch query \
47- --noshow_progress --noshow_loading_progress \
48- ' kind(cc_library, //:all) except filter("experimental|mocks", kind(cc_library, //:all))' |
49- sed -e ' s;//:;;' | grep -E -v ' storage|bigtable|spanner|pubsub|common|grpc_utils' )
47+ mapfile -t ga < <( cmake -DCMAKE_MODULE_PATH=" ${PWD} /cmake" \
48+ -P cmake/print-ga-libraries.cmake 2>&1 |
49+ grep -E -v ' storage|bigtable|spanner|pubsub|common|grpc_utils' )
5050```
5151
5252### ` CHANGELOG.md `
@@ -128,8 +128,9 @@ for lib in "${ga[@]}"; do sed -i 's/experimental-//' google/cloud/${lib}/quickst
128128
129129## (Eventually) Remove the ` experimental- ` rules and targets
130130
131- In the following release, move the libraries from ` TRANSITION_LIBRARIES ` to
132- ` GA_LIBRARIES ` , in the top-level ` BUILD.bazel ` .
131+ In the following release, move the libraries from
132+ ` GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES ` to ` GOOGLE_CLOUD_CPP_GA_LIBRARIES ` , in
133+ ` cmake/GoogleCloudCppFeatures.cmake ` .
133134
134135Then remove the CMake aliases.
135136
0 commit comments