Skip to content

Commit c63e264

Browse files
dbolducdbolduc
authored
feat: expand trivial libraries (#12184)
1 parent 319a899 commit c63e264

190 files changed

Lines changed: 23402 additions & 20 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎CHANGELOG.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,26 @@ The library has been expanded to include the Reporting API.
118118

119119
The library has been expanded to include the [Snooze][monitoring-snooze] API.
120120

121+
### [Cloud Run](/google/cloud/run/README.md)
122+
123+
The library has been expanded to include the
124+
[Job Executions][cloud-run-jobs] API.
125+
121126
### [Compute Engine OS Config](/google/cloud/osconfig/README.md)
122127

123128
The library has been expanded to include the Zonal OS Config API.
124129

130+
### [Dataproc](/google/cloud/dataproc/README.md)
131+
132+
The library has been expanded to include the [Node Groups][dataproc-node-groups]
133+
API.
134+
135+
### [Logging](/google/cloud/logging/README.md)
136+
137+
The library has been expanded to include the
138+
[Log-based Metrics][logging-metrics] API and the [Log Router][logging-config]
139+
API.
140+
125141
### [Retail](/google/cloud/retail/README.md)
126142

127143
The library has been expanded to include new services.
@@ -3668,13 +3684,17 @@ releases. The relevant notes are:
36683684
[cloud bigtable admin api]: https://cloud.google.com/bigtable/docs/reference/admin/rpc
36693685
[cloud tasks]: /google/cloud/tasks/README.md
36703686
[cloud-debugger-deprecated]: https://cloud.google.com/debugger/docs/deprecations
3687+
[cloud-run-jobs]: https://cloud.google.com/run/docs/managing/job-executions
3688+
[dataproc-node-groups]: https://cloud.google.com/dataproc/docs/guides/node-groups/dataproc-driver-node-groups
36713689
[github-cpp-common]: https://github.com/googleapis/google-cloud-cpp-common
36723690
[google.pubsub.v1.schemaserviceclient]: https://cloud.google.com/pubsub/docs/reference/rpc/google.pubsub.v1#google.pubsub.v1.SchemaService
36733691
[guac-dox]: https://cloud.google.com/cpp/docs/reference/common/latest/group__guac
36743692
[howto-mock-data-api]: https://cloud.google.com/cpp/docs/reference/bigtable/latest/bigtable-mocking
36753693
[iam-conditions-link]: https://cloud.google.com/iam/docs/conditions-overview
36763694
[iam-policy-link]: https://cloud.google.com/iam/docs/manage-access-other-resources
36773695
[issue-2567]: https://github.com/googleapis/google-cloud-cpp/issues/2567
3696+
[logging-config]: https://cloud.google.com/logging/docs/routing/overview
3697+
[logging-metrics]: https://cloud.google.com/logging/docs/logs-based-metrics
36783698
[modern-table-ctor]: https://github.com/googleapis/google-cloud-cpp/blob/62740c8e9180056db77d4dd3e80a6fa7ae71295a/google/cloud/bigtable/table.h#L182-L214
36793699
[monitoring-snooze]: https://cloud.google.com/monitoring/alerts/snooze
36803700
[nlohmann-json-gh]: https://github.com/nlohmann/json.git

‎ci/abi-dumps/google_cloud_cpp_dataproc.expected.abi.dump.gz‎

132 KB
Binary file not shown.

‎ci/abi-dumps/google_cloud_cpp_logging.expected.abi.dump.gz‎

382 KB
Binary file not shown.

‎ci/abi-dumps/google_cloud_cpp_run.expected.abi.dump.gz‎

359 KB
Binary file not shown.

‎generator/generator_config.textproto‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1705,6 +1705,14 @@ service {
17051705
endpoint_location_style: LOCATION_DEPENDENT_COMPAT
17061706
}
17071707
1708+
service {
1709+
service_proto_path: "google/cloud/dataproc/v1/node_groups.proto"
1710+
product_path: "google/cloud/dataproc/v1"
1711+
initial_copyright_year: "2023"
1712+
retryable_status_codes: ["kUnavailable"]
1713+
endpoint_location_style: LOCATION_DEPENDENT
1714+
}
1715+
17081716
service {
17091717
service_proto_path: "google/cloud/dataproc/v1/workflow_templates.proto"
17101718
product_path: "google/cloud/dataproc/v1"
@@ -2270,6 +2278,20 @@ service {
22702278
retryable_status_codes: ["kInternal", "kUnavailable"]
22712279
}
22722280
2281+
service {
2282+
service_proto_path: "google/logging/v2/logging_config.proto"
2283+
product_path: "google/cloud/logging/v2"
2284+
initial_copyright_year: "2023"
2285+
retryable_status_codes: ["kUnavailable"]
2286+
}
2287+
2288+
service {
2289+
service_proto_path: "google/logging/v2/logging_metrics.proto"
2290+
product_path: "google/cloud/logging/v2"
2291+
initial_copyright_year: "2023"
2292+
retryable_status_codes: ["kUnavailable"]
2293+
}
2294+
22732295
# Managed Microsoft Active Directory (Managed Microsoft AD or Managed Identities)
22742296
service {
22752297
service_proto_path: "google/cloud/managedidentities/v1/managed_identities_service.proto"
@@ -2718,6 +2740,20 @@ service {
27182740
}
27192741
27202742
# Cloud Run
2743+
service {
2744+
service_proto_path: "google/cloud/run/v2/execution.proto"
2745+
product_path: "google/cloud/run/v2"
2746+
initial_copyright_year: "2023"
2747+
retryable_status_codes: ["kUnavailable"]
2748+
}
2749+
2750+
service {
2751+
service_proto_path: "google/cloud/run/v2/job.proto"
2752+
product_path: "google/cloud/run/v2"
2753+
initial_copyright_year: "2023"
2754+
retryable_status_codes: ["kUnavailable"]
2755+
}
2756+
27212757
service {
27222758
service_proto_path: "google/cloud/run/v2/revision.proto"
27232759
product_path: "google/cloud/run/v2"
@@ -2735,6 +2771,13 @@ service {
27352771
retryable_status_codes: ["kUnavailable"]
27362772
}
27372773
2774+
service {
2775+
service_proto_path: "google/cloud/run/v2/task.proto"
2776+
product_path: "google/cloud/run/v2"
2777+
initial_copyright_year: "2023"
2778+
retryable_status_codes: ["kUnavailable"]
2779+
}
2780+
27382781
# Scheduler
27392782
service {
27402783
service_proto_path: "google/cloud/scheduler/v1/cloudscheduler.proto"

‎generator/internal/descriptor_utils.cc‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,38 @@ auto constexpr kDialogflowESSessionEntityTypeDisplayNameCpp = R"""(
351351
projects/<Project ID>/agent/environments/<Environment ID>/users/<User ID>/sessions/<Session ID>/entityTypes/<Entity Type Display Name>
352352
@endcode)""";
353353

354+
auto constexpr kLoggingConfigClientProto1 =
355+
R"""( The resource name of the link:
356+
357+
"projects/[PROJECT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID]"
358+
"organizations/[ORGANIZATION_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID]"
359+
"billingAccounts/[BILLING_ACCOUNT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID]"
360+
"folders/[FOLDER_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID])""";
361+
362+
auto constexpr kLoggingConfigClientCpp1 =
363+
R"""( The resource name of the link:
364+
365+
"projects/[PROJECT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID]"
366+
"organizations/[ORGANIZATION_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID]"
367+
"billingAccounts/[BILLING_ACCOUNT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID]"
368+
"folders/[FOLDER_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/[LINK_ID]")""";
369+
370+
auto constexpr kLoggingConfigClientProto2 =
371+
R"""( The parent resource whose links are to be listed:
372+
373+
"projects/[PROJECT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/links/"
374+
"organizations/[ORGANIZATION_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/"
375+
"billingAccounts/[BILLING_ACCOUNT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/"
376+
"folders/[FOLDER_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]/)""";
377+
378+
auto constexpr kLoggingConfigClientCpp2 =
379+
R"""( The parent resource whose links are to be listed:
380+
381+
"projects/[PROJECT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]"
382+
"organizations/[ORGANIZATION_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]"
383+
"billingAccounts/[BILLING_ACCOUNT_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]"
384+
"folders/[FOLDER_ID]/locations/[LOCATION_ID]/buckets/[BUCKET_ID]")""";
385+
354386
ParameterCommentSubstitution substitutions[] = {
355387
// From dialogflow/cx/v3.
356388
{kDialogflowCXEnvironmentIdProto1, kDialogflowCXEnvironmentIdCpp1},
@@ -366,6 +398,10 @@ ParameterCommentSubstitution substitutions[] = {
366398
{kDialogflowESSessionEntityTypeDisplayNameProto,
367399
kDialogflowESSessionEntityTypeDisplayNameCpp},
368400

401+
// From logging/v2.
402+
{kLoggingConfigClientProto1, kLoggingConfigClientCpp1},
403+
{kLoggingConfigClientProto2, kLoggingConfigClientCpp2},
404+
369405
// From artifactregistry/v1, where a missing closing quote confuses
370406
// the Doxygen parser.
371407
{R"""("projects/p1/locations/us-central1/repositories/repo1)""",

‎generator/internal/format_method_comments.cc‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,16 @@ std::string FormatMethodComments(
123123
GCP_LOG(FATAL) << __FILE__ << ":" << __LINE__ << ": " << method.full_name()
124124
<< " no leading_comments to format";
125125
}
126-
std::string doxygen_formatted_function_comments =
127-
absl::StrReplaceAll(method_source_location.leading_comments,
128-
{{"\n", "\n ///"}, {"$", "$$"}});
126+
std::string doxygen_formatted_function_comments = absl::StrReplaceAll(
127+
method_source_location.leading_comments,
128+
{
129+
{"\n", "\n ///"},
130+
{"$", "$$"},
131+
// TODO(#12190) - track whether this substitution is used. \
132+
// From logging/v2
133+
{R"""(Gets a view on a log bucket..)""",
134+
R"""(Gets a view on a log bucket.)"""},
135+
});
129136

130137
auto const options_comment = std::string{
131138
R"""( /// @param opts Optional. Override the class-level options, such as retry and

‎google/cloud/dataproc/doc/environment-variables.dox‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ environment variables are convenient when troubleshooting problems.
2626
`EndpointOption` (which defaults to "<location>-dataproc.googleapis.com")
2727
used by `MakeJobControllerConnection()`.
2828

29+
- `GOOGLE_CLOUD_CPP_NODE_GROUP_CONTROLLER_ENDPOINT=...` overrides the
30+
`EndpointOption` (which defaults to "<location>-dataproc.googleapis.com")
31+
used by `MakeNodeGroupControllerConnection()`.
32+
2933
- `GOOGLE_CLOUD_CPP_WORKFLOW_TEMPLATE_SERVICE_ENDPOINT=...` overrides the
3034
`EndpointOption` (which defaults to "<location>-dataproc.googleapis.com")
3135
used by `MakeWorkflowTemplateServiceConnection()`.

‎google/cloud/dataproc/doc/main.dox‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ application.
3737
- [\c dataproc_v1::BatchControllerClient](@ref google::cloud::dataproc_v1::BatchControllerClient)
3838
- [\c dataproc_v1::ClusterControllerClient](@ref google::cloud::dataproc_v1::ClusterControllerClient)
3939
- [\c dataproc_v1::JobControllerClient](@ref google::cloud::dataproc_v1::JobControllerClient)
40+
- [\c dataproc_v1::NodeGroupControllerClient](@ref google::cloud::dataproc_v1::NodeGroupControllerClient)
4041
- [\c dataproc_v1::WorkflowTemplateServiceClient](@ref google::cloud::dataproc_v1::WorkflowTemplateServiceClient)
4142
<!-- inject-client-list-end -->
4243

‎google/cloud/dataproc/doc/override-authentication.dox‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Follow these links to find examples for other \c *Client classes:
1717
- [\c dataproc_v1::BatchControllerClient](@ref dataproc_v1::BatchControllerClient-service-account-snippet)
1818
- [\c dataproc_v1::ClusterControllerClient](@ref dataproc_v1::ClusterControllerClient-service-account-snippet)
1919
- [\c dataproc_v1::JobControllerClient](@ref dataproc_v1::JobControllerClient-service-account-snippet)
20+
- [\c dataproc_v1::NodeGroupControllerClient](@ref dataproc_v1::NodeGroupControllerClient-service-account-snippet)
2021
- [\c dataproc_v1::WorkflowTemplateServiceClient](@ref dataproc_v1::WorkflowTemplateServiceClient-service-account-snippet)
2122

2223
<!-- inject-service-account-snippet-end -->
@@ -59,6 +60,12 @@ guide for more details.
5960

6061
*/
6162

63+
/*! @page dataproc_v1::NodeGroupControllerClient-service-account-snippet Override dataproc_v1::NodeGroupControllerClient Authentication Defaults
64+
65+
@snippet google/cloud/dataproc/v1/samples/node_group_controller_client_samples.cc with-service-account
66+
67+
*/
68+
6269
/*! @page dataproc_v1::WorkflowTemplateServiceClient-service-account-snippet Override dataproc_v1::WorkflowTemplateServiceClient Authentication Defaults
6370

6471
@snippet google/cloud/dataproc/v1/samples/workflow_template_client_samples.cc with-service-account

0 commit comments

Comments
 (0)