resolving comments

shubham-up-47 · shubham-up-47 · commit 8eecba263675 · 2025-10-08T15:26:07.000Z
diff --git a/google/cloud/storage/internal/async/writer_connection_buffered.cc b/google/cloud/storage/internal/async/writer_connection_buffered.cc
@@ -397,7 +397,7 @@ class AsyncWriterConnectionBufferedState
     flush_ = false;
     // Check if the promise has already been completed.
     if (finalized_promise_completed_) {
-      lk.unlock();  // Release lock before returning
+      // Since the lock is passed by value, no explicit unlock is needed.
       return;
     }
     // Mark the promise as completed *before* moving it.

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ class AsyncWriterConnectionBufferedState`
`397`	`397`	`flush_ = false;`
`398`	`398`	`// Check if the promise has already been completed.`
`399`	`399`	`if (finalized_promise_completed_) {`
`400`		`- lk.unlock(); // Release lock before returning`
	`400`	`+ // Since the lock is passed by value, no explicit unlock is needed.`
`401`	`401`	`return;`
`402`	`402`	`}`
`403`	`403`	`// Mark the promise as completed before moving it.`