Skip to content

Commit 634e84c

Browse files
scotthartscotthart
authored
refactor: AsyncRestPollingLoopImpl template location to reduce compile time (#13418)
1 parent 0d8ac58 commit 634e84c

92 files changed

Lines changed: 1119 additions & 805 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎generator/internal/connection_impl_rest_generator.cc‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,17 +141,24 @@ Status ConnectionImplRestGenerator::GenerateCc() {
141141
)""");
142142

143143
auto const needs_async_retry_loop = !async_methods().empty();
144+
std::string lro_extract_include;
145+
std::string lro_op_include;
146+
if (HasLongrunningMethod()) {
147+
lro_extract_include = "google/cloud/internal/extract_long_running_result.h";
148+
if (HasGRPCLongrunningOperation()) {
149+
lro_op_include =
150+
"google/cloud/internal/async_rest_long_running_operation.h";
151+
} else {
152+
lro_op_include =
153+
"google/cloud/internal/async_rest_long_running_operation_custom.h";
154+
}
155+
}
144156
CcLocalIncludes(
145157
{vars("connection_impl_rest_header_path"),
146158
vars("stub_factory_rest_header_path"), "google/cloud/common_options.h",
147159
"google/cloud/credentials.h", "google/cloud/rest_options.h",
148160
HasPaginatedMethod() ? "google/cloud/internal/pagination_range.h" : "",
149-
HasLongrunningMethod()
150-
? "google/cloud/internal/extract_long_running_result.h"
151-
: "",
152-
HasLongrunningMethod()
153-
? "google/cloud/internal/async_rest_long_running_operation.h"
154-
: "",
161+
std::move(lro_extract_include), std::move(lro_op_include),
155162
needs_async_retry_loop ? "google/cloud/internal/async_rest_retry_loop.h"
156163
: "",
157164
"google/cloud/internal/rest_retry_loop.h"});

‎google/cloud/compute/addresses/v1/internal/addresses_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/addresses/v1/internal/addresses_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/autoscalers/v1/internal/autoscalers_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/autoscalers/v1/internal/autoscalers_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/backend_buckets/v1/internal/backend_buckets_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/backend_buckets/v1/internal/backend_buckets_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/backend_services/v1/internal/backend_services_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/backend_services/v1/internal/backend_services_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/disks/v1/internal/disks_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/disks/v1/internal/disks_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/external_vpn_gateways/v1/internal/external_vpn_gateways_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include "google/cloud/compute/external_vpn_gateways/v1/internal/external_vpn_gateways_rest_stub_factory.h"
2222
#include "google/cloud/common_options.h"
2323
#include "google/cloud/credentials.h"
24-
#include "google/cloud/internal/async_rest_long_running_operation.h"
24+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2525
#include "google/cloud/internal/extract_long_running_result.h"
2626
#include "google/cloud/internal/pagination_range.h"
2727
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/firewall_policies/v1/internal/firewall_policies_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/firewall_policies/v1/internal/firewall_policies_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/firewalls/v1/internal/firewalls_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/firewalls/v1/internal/firewalls_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

‎google/cloud/compute/forwarding_rules/v1/internal/forwarding_rules_rest_connection_impl.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "google/cloud/compute/forwarding_rules/v1/internal/forwarding_rules_rest_stub_factory.h"
2121
#include "google/cloud/common_options.h"
2222
#include "google/cloud/credentials.h"
23-
#include "google/cloud/internal/async_rest_long_running_operation.h"
23+
#include "google/cloud/internal/async_rest_long_running_operation_custom.h"
2424
#include "google/cloud/internal/extract_long_running_result.h"
2525
#include "google/cloud/internal/pagination_range.h"
2626
#include "google/cloud/internal/rest_retry_loop.h"

0 commit comments

Comments
 (0)