Skip to content

Commit 555586f

Browse files
alevenbergalevenberg
authored
fix(internal): change url_encode include from .h to .cc (#12547)
* fix: change include from .h to .cc * generate libraries
1 parent b13b794 commit 555586f

576 files changed

Lines changed: 300 additions & 299 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎generator/integration_tests/golden/v1/internal/golden_kitchen_sink_metadata_decorator.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "google/cloud/internal/absl_str_join_quiet.h"
2323
#include "google/cloud/internal/api_client_header.h"
2424
#include "google/cloud/internal/routing_matcher.h"
25+
#include "google/cloud/internal/url_encode.h"
2526
#include "google/cloud/status_or.h"
2627
#include <generator/integration_tests/test.grpc.pb.h>
2728
#include <memory>

‎generator/integration_tests/golden/v1/internal/golden_kitchen_sink_metadata_decorator.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#define GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_GOLDEN_KITCHEN_SINK_METADATA_DECORATOR_H
2121

2222
#include "generator/integration_tests/golden/v1/internal/golden_kitchen_sink_stub.h"
23-
#include "google/cloud/internal/url_encode.h"
2423
#include "google/cloud/version.h"
2524
#include <map>
2625
#include <memory>

‎generator/integration_tests/golden/v1/internal/golden_thing_admin_metadata_decorator.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "google/cloud/internal/absl_str_join_quiet.h"
2323
#include "google/cloud/internal/api_client_header.h"
2424
#include "google/cloud/internal/routing_matcher.h"
25+
#include "google/cloud/internal/url_encode.h"
2526
#include "google/cloud/status_or.h"
2627
#include <generator/integration_tests/test.grpc.pb.h>
2728
#include <memory>

‎generator/integration_tests/golden/v1/internal/golden_thing_admin_metadata_decorator.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#define GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_GOLDEN_THING_ADMIN_METADATA_DECORATOR_H
2121

2222
#include "generator/integration_tests/golden/v1/internal/golden_thing_admin_stub.h"
23-
#include "google/cloud/internal/url_encode.h"
2423
#include "google/cloud/version.h"
2524
#include <google/longrunning/operations.grpc.pb.h>
2625
#include <map>

‎generator/internal/metadata_decorator_generator.cc‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ Status MetadataDecoratorGenerator::GenerateHeader() {
123123

124124
// includes
125125
HeaderPrint("\n");
126-
HeaderLocalIncludes({vars("stub_header_path"), "google/cloud/version.h",
127-
"google/cloud/internal/url_encode.h"});
126+
HeaderLocalIncludes({vars("stub_header_path"), "google/cloud/version.h"});
128127
HeaderSystemIncludes(
129128
{HasLongrunningMethod() ? "google/longrunning/operations.grpc.pb.h" : "",
130129
"map", "memory", "string"});
@@ -173,16 +172,17 @@ Status MetadataDecoratorGenerator::GenerateCc() {
173172

174173
// includes
175174
CcPrint("\n");
176-
CcLocalIncludes(
177-
{vars("metadata_header_path"),
178-
"google/cloud/internal/absl_str_cat_quiet.h",
179-
HasExplicitRoutingMethod()
180-
? "google/cloud/internal/absl_str_join_quiet.h"
181-
: "",
182-
"google/cloud/internal/api_client_header.h",
183-
HasExplicitRoutingMethod() ? "google/cloud/internal/routing_matcher.h"
184-
: "",
185-
"google/cloud/common_options.h", "google/cloud/status_or.h"});
175+
CcLocalIncludes({vars("metadata_header_path"),
176+
"google/cloud/internal/absl_str_cat_quiet.h",
177+
HasExplicitRoutingMethod()
178+
? "google/cloud/internal/absl_str_join_quiet.h"
179+
: "",
180+
"google/cloud/internal/api_client_header.h",
181+
HasExplicitRoutingMethod()
182+
? "google/cloud/internal/routing_matcher.h"
183+
: "",
184+
"google/cloud/common_options.h", "google/cloud/status_or.h",
185+
"google/cloud/internal/url_encode.h"});
186186
CcSystemIncludes({vars("proto_grpc_header_path"), "memory"});
187187

188188
auto result = CcOpenNamespaces(NamespaceType::kInternal);

‎google/cloud/accessapproval/v1/internal/access_approval_metadata_decorator.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
#include "google/cloud/common_options.h"
2121
#include "google/cloud/internal/absl_str_cat_quiet.h"
2222
#include "google/cloud/internal/api_client_header.h"
23+
#include "google/cloud/internal/url_encode.h"
2324
#include "google/cloud/status_or.h"
2425
#include <google/cloud/accessapproval/v1/accessapproval.grpc.pb.h>
2526
#include <memory>

‎google/cloud/accessapproval/v1/internal/access_approval_metadata_decorator.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_ACCESSAPPROVAL_V1_INTERNAL_ACCESS_APPROVAL_METADATA_DECORATOR_H
2121

2222
#include "google/cloud/accessapproval/v1/internal/access_approval_stub.h"
23-
#include "google/cloud/internal/url_encode.h"
2423
#include "google/cloud/version.h"
2524
#include <map>
2625
#include <memory>

‎google/cloud/accesscontextmanager/v1/internal/access_context_manager_metadata_decorator.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
#include "google/cloud/common_options.h"
2121
#include "google/cloud/internal/absl_str_cat_quiet.h"
2222
#include "google/cloud/internal/api_client_header.h"
23+
#include "google/cloud/internal/url_encode.h"
2324
#include "google/cloud/status_or.h"
2425
#include <google/identity/accesscontextmanager/v1/access_context_manager.grpc.pb.h>
2526
#include <memory>

‎google/cloud/accesscontextmanager/v1/internal/access_context_manager_metadata_decorator.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_ACCESSCONTEXTMANAGER_V1_INTERNAL_ACCESS_CONTEXT_MANAGER_METADATA_DECORATOR_H
2121

2222
#include "google/cloud/accesscontextmanager/v1/internal/access_context_manager_stub.h"
23-
#include "google/cloud/internal/url_encode.h"
2423
#include "google/cloud/version.h"
2524
#include <google/longrunning/operations.grpc.pb.h>
2625
#include <map>

‎google/cloud/advisorynotifications/v1/internal/advisory_notifications_metadata_decorator.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
#include "google/cloud/common_options.h"
2121
#include "google/cloud/internal/absl_str_cat_quiet.h"
2222
#include "google/cloud/internal/api_client_header.h"
23+
#include "google/cloud/internal/url_encode.h"
2324
#include "google/cloud/status_or.h"
2425
#include <google/cloud/advisorynotifications/v1/service.grpc.pb.h>
2526
#include <memory>

0 commit comments

Comments
 (0)