Skip to content

Commit 380be36

Browse files
coryancoryan
authored
cleanup(bigquery): remove unusable code (#11404)
1 parent e942516 commit 380be36

42 files changed

Lines changed: 8 additions & 2570 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,12 @@ The following experimental libraries are now available:
138138

139139
The library has been expanded to include the v2 service.
140140

141+
### [Bigquery](/google/cloud/bigquery/README.md)
142+
143+
- Removed bigquery/v2/model\*. There are no plans to implement gRPC endpoints for
144+
this service. Therefore the generated code will never be usable and never has
145+
been.
146+
141147
### Other Changes
142148

143149
**Bazel Testing**: starting with v2.10.0 we only test with Bazel >= 5.4.0. We

‎ci/abi-dumps/google_cloud_cpp_bigquery.expected.abi.dump.gz‎

-63.8 KB
Binary file not shown.

‎ci/cloudbuild/builds/cmake-install.sh‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ expected_dirs+=(
6262
# no RPC services in google/cloud/bigquery/logging
6363
./include/google/cloud/bigquery/logging
6464
./include/google/cloud/bigquery/logging/v1
65+
./include/google/cloud/bigquery/v2
6566
./include/google/cloud/bigquery/v2/minimal
6667
./include/google/cloud/bigquery/v2/minimal/internal
6768
./include/google/cloud/bigquery/v2/minimal/mocks

‎ci/etc/expected_install_directories‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,6 @@
138138
./include/google/cloud/bigquery/storage/v1
139139
./include/google/cloud/bigquery/storage/v1/internal
140140
./include/google/cloud/bigquery/storage/v1/mocks
141-
./include/google/cloud/bigquery/v2
142-
./include/google/cloud/bigquery/v2/internal
143-
./include/google/cloud/bigquery/v2/mocks
144141
./include/google/cloud/bigtable
145142
./include/google/cloud/bigtable/admin
146143
./include/google/cloud/bigtable/admin/internal

‎generator/generator_config.textproto‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -262,14 +262,6 @@ service {
262262
retryable_status_codes: ["kUnavailable"]
263263
}
264264

265-
service {
266-
service_proto_path: "google/cloud/bigquery/v2/model.proto"
267-
product_path: "google/cloud/bigquery/v2"
268-
forwarding_product_path: "google/cloud/bigquery"
269-
initial_copyright_year: "2022"
270-
retryable_status_codes: ["kUnavailable"]
271-
}
272-
273265
# Bigtable
274266
service {
275267
service_proto_path: "google/bigtable/v2/bigtable.proto"

‎google/cloud/bigquery/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ service_dirs = [
2525
"migration/v2/",
2626
"reservation/v1/",
2727
"storage/v1/",
28-
"v2/",
2928
]
3029

3130
src_dirs = service_dirs + [d + "internal/" for d in service_dirs]

‎google/cloud/bigquery/bigquery_grpc.cmake‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ set(service_dirs
2424
"datatransfer/v1/"
2525
"migration/v2/"
2626
"reservation/v1/"
27-
"storage/v1/"
28-
"v2/")
27+
"storage/v1/")
2928
foreach (dir IN LISTS service_dirs)
3029
string(REPLACE "/" "_" ns "${dir}")
3130
list(APPEND source_globs "${dir}*.h" "${dir}*.cc" "${dir}internal/*")

‎google/cloud/bigquery/doc/environment-variables.dox‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ environment variables are convenient when troubleshooting problems.
3838
`EndpointOption` (which defaults to "bigquerymigration.googleapis.com")
3939
used by `MakeMigrationServiceConnection()`.
4040

41-
- `GOOGLE_CLOUD_CPP_MODEL_SERVICE_ENDPOINT=...` overrides the
42-
`EndpointOption` (which defaults to "bigquery.googleapis.com")
43-
used by `MakeModelServiceConnection()`.
44-
4541
- `GOOGLE_CLOUD_CPP_RESERVATION_SERVICE_ENDPOINT=...` overrides the
4642
`EndpointOption` (which defaults to "bigqueryreservation.googleapis.com")
4743
used by `MakeReservationServiceConnection()`.

‎google/cloud/bigquery/doc/main.dox‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ Follow these links to find examples for other \c *Client classes:
102102
[bigquery_reservation_v1::ReservationServiceClient](@ref bigquery_reservation_v1::ReservationServiceClient-endpoint-snippet)
103103
[bigquery_storage_v1::BigQueryReadClient](@ref bigquery_storage_v1::BigQueryReadClient-endpoint-snippet)
104104
[bigquery_storage_v1::BigQueryWriteClient](@ref bigquery_storage_v1::BigQueryWriteClient-endpoint-snippet)
105-
[bigquery_v2::ModelServiceClient](@ref bigquery_v2::ModelServiceClient-endpoint-snippet)
106105

107106
<!-- inject-endpoint-snippet-end -->
108107

@@ -125,7 +124,6 @@ Follow these links to find examples for other \c *Client classes:
125124
[bigquery_reservation_v1::ReservationServiceClient](@ref bigquery_reservation_v1::ReservationServiceClient-service-account-snippet)
126125
[bigquery_storage_v1::BigQueryReadClient](@ref bigquery_storage_v1::BigQueryReadClient-service-account-snippet)
127126
[bigquery_storage_v1::BigQueryWriteClient](@ref bigquery_storage_v1::BigQueryWriteClient-service-account-snippet)
128-
[bigquery_v2::ModelServiceClient](@ref bigquery_v2::ModelServiceClient-service-account-snippet)
129127

130128
<!-- inject-service-account-snippet-end -->
131129

@@ -250,17 +248,5 @@ guide for more details.
250248

251249
@snippet google/cloud/bigquery/storage/v1/samples/bigquery_write_client_samples.cc with-service-account
252250

253-
*/
254-
255-
/*! @page bigquery_v2::ModelServiceClient-endpoint-snippet Override bigquery_v2::ModelServiceClient Endpoint Configuration
256-
257-
@snippet google/cloud/bigquery/v2/samples/model_client_samples.cc set-client-endpoint
258-
259-
*/
260-
261-
/*! @page bigquery_v2::ModelServiceClient-service-account-snippet Override bigquery_v2::ModelServiceClient Authentication Defaults
262-
263-
@snippet google/cloud/bigquery/v2/samples/model_client_samples.cc with-service-account
264-
265251
*/
266252
// <!-- inject-endpoint-pages-end -->

‎google/cloud/bigquery/mocks/mock_model_connection.h‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)