impl: faster check-api runs (#11719)

dbolduc · web-flow · commit 12600479a816 · 2023-05-25T07:48:43.000-04:00
diff --git a/ci/cloudbuild/builds/check-api.sh b/ci/cloudbuild/builds/check-api.sh
@@ -41,9 +41,13 @@ io::run cmake "${cmake_args[@]}" \
 io::run cmake --build cmake-out
 io::run cmake --install cmake-out >/dev/null
 
-mapfile -t ga_list < <(cmake -DCMAKE_MODULE_PATH="${PWD}/cmake" -P cmake/print-ga-libraries.cmake 2>&1)
-# These libraries are not "features", but they are part of the public API
-ga_list+=("common" "grpc_utils")
+if [ "${GOOGLE_CLOUD_CPP_CHECK_API:-}" ]; then
+  IFS=',' read -ra library_list <<<"${GOOGLE_CLOUD_CPP_CHECK_API}"
+else
+  mapfile -t library_list < <(cmake -DCMAKE_MODULE_PATH="${PWD}/cmake" -P cmake/print-ga-libraries.cmake 2>&1)
+  # These libraries are not "features", but they are part of the public API
+  library_list+=("common" "grpc_utils")
+fi
 
 # Uses `abi-dumper` to dump the ABI for the given library, which should
 # be installed at the given @p prefix, and `abi-compliance-checker` to
@@ -131,7 +135,7 @@ function check_abi() {
 }
 export -f check_abi # enables this function to be called from a subshell
 
-mapfile -t libraries < <(printf "google_cloud_cpp_%s\n" "${ga_list[@]}")
+mapfile -t libraries < <(printf "google_cloud_cpp_%s\n" "${library_list[@]}")
 
 # Run the check_abi function for each library in parallel since it is slow.
 echo "${libraries[@]}" | xargs -P "$(nproc)" -n 1 \
diff --git a/doc/contributor/howto-guide-adding-generated-libraries.md b/doc/contributor/howto-guide-adding-generated-libraries.md
@@ -226,10 +226,8 @@ ci/cloudbuild/build.sh -t checkers-pr
 For new GA libraries you need to create the API baseline.
 
 ```
-ci/cloudbuild/build.sh -t check-api-pr
-git add ci/abi-dumps/google_cloud_cpp_${library}.expected.abi.dump.gz
-git commit -m"Add API baseline" ci/abi-dumps/google_cloud_cpp_${library}.expected.abi.dump.gz
-git restore ci/abi-dumps/
+env GOOGLE_CLOUD_CPP_CHECK_API=${library} ci/cloudbuild/build.sh -t check-api-pr
+git commit -m"Add API baseline" ci/abi-dumps/
 ```
 
 ## Verify everything compiles
