Skip to content

fix: Removed indent from discovery cache json files#2099

Merged
parthea merged 2 commits into
googleapis:mainfrom
jorenham:patch-1
Jan 8, 2024
Merged

fix: Removed indent from discovery cache json files#2099
parthea merged 2 commits into
googleapis:mainfrom
jorenham:patch-1

Conversation

@jorenham
Copy link
Copy Markdown
Contributor

@jorenham jorenham commented Apr 1, 2023

This should bring down the size by 15-30%.
Towards #1967

@jorenham jorenham requested a review from a team April 1, 2023 00:34
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Apr 1, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Apr 1, 2023
@jorenham jorenham changed the title Removed json indentation in generated discovery cache json files removed indent from discovery cache json files Apr 1, 2023
@jorenham jorenham changed the title removed indent from discovery cache json files fix: Removed indent from discovery cache json files Apr 1, 2023
@jorenham
Copy link
Copy Markdown
Contributor Author

jorenham commented Apr 1, 2023

I gotta say, the amount of effort that is required to propose this 1 character change is borderline Kafkaesque.

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 24, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 24, 2023
@jorenham jorenham requested a review from parthea July 18, 2023 16:38
jorenham and others added 2 commits September 20, 2023 05:19
Changed the discovery artifact JSON indentation from 2 to 0, in
order to reduce the size by several megabytes.

Refs: #1967
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 8, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 8, 2024
@parthea parthea self-assigned this Jan 8, 2024
@parthea parthea merged commit 0a28454 into googleapis:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants