Run tests against PHP 7.3+ and check for cross-version support… (#1684)

swissspidy · jdpedrie · commit 7826dd0c1412 · 2019-07-31T14:30:17.000-04:00
* Move phpcs config to root folder

* Run tests against PHP 7.3 and PHP 7.4

* Check for cross-version support for PHP 5.4 and higher

* Only downgrade guzzle and phpseclib on Travis

Prevents downgrading dev dependencies
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,6 @@
 .DS_Store
 phpunit.xml
+phpcs.xml
 composer.lock
 vendor
 examples/testfile-small.txt
diff --git a/.travis.yml b/.travis.yml
@@ -23,13 +23,17 @@ php:
   - 7.0
   - 7.1
   - 7.2
+  - 7.3
+  - 7.4snapshot
 
 # Test lowest dependencies on PHP 5.4
 # (Guzzle 5.2, phpseclib 0.3)
 matrix:
   include:
     - php: 5.4
-      env: COMPOSER_CMD="composer update --prefer-lowest" RUN_PHP_CS=true
+      env: COMPOSER_CMD="composer update phpseclib/phpseclib guzzlehttp/guzzle guzzlehttp/psr7 --prefer-lowest" RUN_PHP_CS=true
+  allow_failures:
+    - php: 7.4snapshot
 
 before_install:
   - composer self-update
@@ -44,4 +48,4 @@ before_script:
 
 script:
   - vendor/bin/phpunit
-  - if [[ "$RUN_PHP_CS" == "true" ]]; then vendor/bin/phpcs src --standard=style/ruleset.xml -np; fi
+  - if [[ "$RUN_PHP_CS" == "true" ]]; then vendor/bin/phpcs src -np; fi
diff --git a/composer.json b/composer.json
@@ -20,7 +20,9 @@
         "squizlabs/php_codesniffer": "~2.3",
         "symfony/dom-crawler": "~2.1",
         "symfony/css-selector": "~2.1",
-        "cache/filesystem-adapter": "^0.3.2"
+        "cache/filesystem-adapter": "^0.3.2",
+        "phpcompatibility/php-compatibility": "^9.2",
+        "dealerdirect/phpcodesniffer-composer-installer": "^0.5.0"
     },
     "suggest": {
         "cache/filesystem-adapter": "For caching certs and tokens (using Google_Client::setCache)"
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -10,6 +10,11 @@
  <!-- PHP code MUST use only UTF-8 without BOM. -->
  <rule ref="Generic.Files.ByteOrderMark"/>
 
+ <!-- Check for cross-version support for PHP 5.4 and higher. -->
+ <rule ref="PHPCompatibility">
+  <config name="testVersion" value="5.4-"/>
+ </rule>
+
  <!-- Check for duplicated class names -->
  <rule ref="Generic.Classes.DuplicateClassName" />
 
