Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

feat: Support alternative http bindings in the gapic schema.#993

Merged
software-dov merged 6 commits intogoogleapis:masterfrom
kbandes:kbandes-xcode
Sep 15, 2021
Merged

feat: Support alternative http bindings in the gapic schema.#993
software-dov merged 6 commits intogoogleapis:masterfrom
kbandes:kbandes-xcode

Conversation

@kbandes
Copy link
Copy Markdown
Contributor

@kbandes kbandes commented Sep 14, 2021

This completes part of yon-mg's PR, #776. The template changes will be in a separate PR.

@kbandes kbandes requested a review from a team September 14, 2021 19:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021
@kbandes kbandes changed the title Support alternative http bindings in the gapic schema. feat: Support alternative http bindings in the gapic schema. Sep 14, 2021
Copy link
Copy Markdown
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: are these additions intended to replace or complement the existing http_opt property? I think we should probably have only one. The names are too similar to be easily distinguished without reading the code.

Comment thread gapic/schema/wrappers.py Outdated
Comment thread gapic/schema/wrappers.py Outdated
Comment thread gapic/schema/wrappers.py Outdated
Comment thread gapic/schema/wrappers.py Outdated
Comment thread gapic/schema/wrappers.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants