From 3aae799f62a1f5d3b0506d919cc6080ee417f14b Mon Sep 17 00:00:00 2001 From: Mira Leung Date: Fri, 25 Sep 2020 14:41:30 -0700 Subject: [PATCH 1/2] fix: handle repeated fields in method signatures (#445) Co-authored-by: Dov Shlachter --- .../%name_%version/%sub/services/%service/client.py.j2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 b/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 index b753848361..ccc4aa85f0 100644 --- a/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 +++ b/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 @@ -338,12 +338,12 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta): # If we have keyword arguments corresponding to fields on the # request, apply these. {% endif -%} - {%- for key, field in method.flattened_fields.items() if not(field.repeated and method.input.ident.package != method.ident.package) %} + {%- for key, field in method.flattened_fields.items() if not(field.repeated or method.input.ident.package != method.ident.package) %} if {{ field.name }} is not None: request.{{ key }} = {{ field.name }} {%- endfor %} {# They can be _extended_, however -#} - {%- for key, field in method.flattened_fields.items() if (field.repeated and method.input.ident.package != method.ident.package) %} + {%- for key, field in method.flattened_fields.items() if field.repeated %} if {{ field.name }}: request.{{ key }}.extend({{ field.name }}) {%- endfor %} From 4a83369d75b2f3f8e64b4714014750d6acf9bff5 Mon Sep 17 00:00:00 2001 From: "release-please[bot]" <55107282+release-please[bot]@users.noreply.github.com> Date: Fri, 25 Sep 2020 16:07:34 -0700 Subject: [PATCH 2/2] chore: release 0.33.8 (#621) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> --- CHANGELOG.md | 7 +++++++ setup.py | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c0d0e37dba..98fd68593d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +### [0.33.8](https://www.github.com/googleapis/gapic-generator-python/compare/v0.33.7...v0.33.8) (2020-09-25) + + +### Bug Fixes + +* handle repeated fields in method signatures ([#445](https://www.github.com/googleapis/gapic-generator-python/issues/445)) ([3aae799](https://www.github.com/googleapis/gapic-generator-python/commit/3aae799f62a1f5d3b0506d919cc6080ee417f14b)) + ### [0.33.7](https://www.github.com/googleapis/gapic-generator-python/compare/v0.33.6...v0.33.7) (2020-09-24) diff --git a/setup.py b/setup.py index f5e1d36cdd..d659a5e488 100644 --- a/setup.py +++ b/setup.py @@ -20,7 +20,7 @@ PACKAGE_ROOT = os.path.abspath(os.path.dirname(__file__)) -version = "0.33.7" +version = "0.33.8" with io.open(os.path.join(PACKAGE_ROOT, "README.rst")) as file_obj: README = file_obj.read()