From c43c5740db099be19c5f6e52b3a917a631003411 Mon Sep 17 00:00:00 2001 From: Dov Shlachter Date: Thu, 17 Sep 2020 09:06:38 -0700 Subject: [PATCH 1/2] fix: 'id' should not be a reserved name (#602) A number of python builtins collide with flattened fields from certain API methods. More common names, especially ones that conflict with builtins that aren't used by the surface, are explicitly allowed. --- gapic/utils/reserved_names.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gapic/utils/reserved_names.py b/gapic/utils/reserved_names.py index 866a867663..14958fc52f 100644 --- a/gapic/utils/reserved_names.py +++ b/gapic/utils/reserved_names.py @@ -24,6 +24,6 @@ RESERVED_NAMES = frozenset( itertools.chain( keyword.kwlist, - set(dir(builtins)) - {"filter", "map"}, + set(dir(builtins)) - {"filter", "map", "id"}, ) ) From b36c54dd22beea2965e5bc85aa4ae7b74df4e4c1 Mon Sep 17 00:00:00 2001 From: "release-please[bot]" <55107282+release-please[bot]@users.noreply.github.com> Date: Thu, 17 Sep 2020 09:26:49 -0700 Subject: [PATCH 2/2] chore: release 0.33.4 (#603) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> --- CHANGELOG.md | 7 +++++++ setup.py | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b31f5515c2..a844d1d5e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +### [0.33.4](https://www.github.com/googleapis/gapic-generator-python/compare/v0.33.3...v0.33.4) (2020-09-17) + + +### Bug Fixes + +* 'id' should not be a reserved name ([#602](https://www.github.com/googleapis/gapic-generator-python/issues/602)) ([c43c574](https://www.github.com/googleapis/gapic-generator-python/commit/c43c5740db099be19c5f6e52b3a917a631003411)) + ### [0.33.3](https://www.github.com/googleapis/gapic-generator-python/compare/v0.33.2...v0.33.3) (2020-09-15) diff --git a/setup.py b/setup.py index ab32647cd9..5a3ccbc1ab 100644 --- a/setup.py +++ b/setup.py @@ -20,7 +20,7 @@ PACKAGE_ROOT = os.path.abspath(os.path.dirname(__file__)) -version = "0.33.3" +version = "0.33.4" with io.open(os.path.join(PACKAGE_ROOT, "README.rst")) as file_obj: README = file_obj.read()