From 443e902c9d702ea1869e5e68d709f3e6ee14485c Mon Sep 17 00:00:00 2001 From: James McTavish Date: Thu, 15 Dec 2022 10:24:17 -0500 Subject: [PATCH 1/2] fix: correctly propagate the firebase app name (#1122) The firebase app name is not being correctly set and in at least some cases will prevent the debug agent from connecting to the firebase database. --- src/agent/firebase-controller.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/agent/firebase-controller.ts b/src/agent/firebase-controller.ts index ac503674..968a56dd 100644 --- a/src/agent/firebase-controller.ts +++ b/src/agent/firebase-controller.ts @@ -98,11 +98,11 @@ export class FirebaseController implements Controller { { databaseURL: databaseUrl, }, - 'cdbg' + FIREBASE_APP_NAME ); } - const db = firebase.database(); + const db = firebase.database(app); // Test the connection by reading the schema version. try { From 2867334a71a031975377b10a059f573113c90ed8 Mon Sep 17 00:00:00 2001 From: "release-please[bot]" <55107282+release-please[bot]@users.noreply.github.com> Date: Thu, 15 Dec 2022 15:40:15 +0000 Subject: [PATCH 2/2] chore(main): release 7.2.1 (#1123) :robot: I have created a release *beep* *boop* --- ## [7.2.1](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v7.2.0...v7.2.1) (2022-12-15) ### Bug Fixes * Correctly propagate the firebase app name ([#1122](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1122)) ([443e902](https://togithub.com/googleapis/cloud-debug-nodejs/commit/443e902c9d702ea1869e5e68d709f3e6ee14485c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). --- CHANGELOG.md | 7 +++++++ package.json | 2 +- samples/package.json | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 145b1ec4..0b020e3e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Node.js Agent for Google Cloud Debug ChangeLog +## [7.2.1](https://github.com/googleapis/cloud-debug-nodejs/compare/v7.2.0...v7.2.1) (2022-12-15) + + +### Bug Fixes + +* Correctly propagate the firebase app name ([#1122](https://github.com/googleapis/cloud-debug-nodejs/issues/1122)) ([443e902](https://github.com/googleapis/cloud-debug-nodejs/commit/443e902c9d702ea1869e5e68d709f3e6ee14485c)) + ## [7.2.0](https://github.com/googleapis/cloud-debug-nodejs/compare/v7.1.1...v7.2.0) (2022-12-09) diff --git a/package.json b/package.json index 8b41f842..62a602fc 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@google-cloud/debug-agent", - "version": "7.2.0", + "version": "7.2.1", "author": "Google Inc.", "description": "Stackdriver Debug Agent for Node.js", "main": "./build/src/index", diff --git a/samples/package.json b/samples/package.json index 2134e48a..d1f8dce1 100644 --- a/samples/package.json +++ b/samples/package.json @@ -17,7 +17,7 @@ "test": "mocha" }, "dependencies": { - "@google-cloud/debug-agent": "^7.2.0", + "@google-cloud/debug-agent": "^7.2.1", "express": "4.18.2" }, "devDependencies": {