chore(deps): drop dependency on is (#855)

JustinBeckwith · web-flow · commit 9a8d85f59c22 · 2020-03-29T22:50:29.000-07:00
diff --git a/package.json b/package.json
@@ -44,7 +44,6 @@
   },
   "dependencies": {
     "@google-cloud/common": "^3.0.0",
-    "@sindresorhus/is": "^1.0.0",
     "acorn": "^7.0.0",
     "coffeescript": "^2.0.0",
     "console-log-level": "^1.4.0",
diff --git a/src/agent/debuglet.ts b/src/agent/debuglet.ts
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import is from '@sindresorhus/is';
 import * as assert from 'assert';
 import * as consoleLogLevel from 'console-log-level';
 import * as crypto from 'crypto';
@@ -546,7 +545,7 @@ export class Debuglet extends EventEmitter {
 
     if (serviceContext) {
       if (
-        is.string(serviceContext.service) &&
+        typeof serviceContext.service === 'string' &&
         serviceContext.service !== 'default'
       ) {
         // As per app-engine-ids, the module label is not reported
@@ -555,12 +554,12 @@ export class Debuglet extends EventEmitter {
         desc += ' module:' + serviceContext.service;
       }
 
-      if (is.string(serviceContext.version)) {
+      if (typeof serviceContext.version === 'string') {
         labels.version = serviceContext.version;
         desc += ' version:' + serviceContext.version;
       }
 
-      if (is.string(serviceContext.minorVersion_)) {
+      if (typeof serviceContext.minorVersion_ === 'string') {
         //          v--- intentional lowercase
         labels.minorversion = serviceContext.minorVersion_;
       }
diff --git a/src/agent/state/inspector-state.ts b/src/agent/state/inspector-state.ts
@@ -14,7 +14,6 @@
 
 // TODO: Unify some common code with state.ts in future PRs.
 
-import is from '@sindresorhus/is';
 import * as inspector from 'inspector';
 import * as util from 'util';
 
@@ -387,7 +386,7 @@ class StateResolver {
     } else {
       locals = this.resolveLocalsList_(frame);
 
-      if (is.emptyArray(locals)) {
+      if (Array.isArray(locals) && locals.length === 0) {
         locals = [];
       }
     }
@@ -453,7 +452,13 @@ class StateResolver {
         objectId: frame.scopeChain[i].object.objectId as string,
       });
       // TODO: Handle when result.error exists.
-      if (result.response && !is.emptyArray(result.response.result)) {
+      if (
+        result.response &&
+        !(
+          Array.isArray(result.response.result) &&
+          result.response.result.length === 0
+        )
+      ) {
         for (let j = 0; j < result.response.result.length; ++j) {
           if (!usedNames[result.response.result[j].name]) {
             // It's a valid variable that belongs in the locals list
diff --git a/src/agent/state/legacy-state.ts b/src/agent/state/legacy-state.ts
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import is from '@sindresorhus/is';
 import * as util from 'util';
 import * as vm from 'vm';
 
@@ -366,7 +365,7 @@ class StateResolver {
       // in locals which will include any applicable arguments from the
       // invocation.
       locals = this.resolveLocalsList_(frame);
-      if (is.emptyArray(locals)) {
+      if (Array.isArray(locals) && locals.length === 0) {
         locals = [];
       }
     }
diff --git a/src/agent/util/utils.ts b/src/agent/util/utils.ts
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import is from '@sindresorhus/is';
 import * as inspector from 'inspector';
 import * as path from 'path';
 import * as semver from 'semver';
@@ -65,7 +64,7 @@ export function findScripts(
   // (path: string, knownFiles: string[], resolved: string[]) => string[]
   const resolved = resolveScripts(scriptPath, config, fileStats);
   if (config.pathResolver) {
-    if (!is.function_(config.pathResolver)) {
+    if (typeof config.pathResolver !== 'function') {
       logger.warn(
         `The 'pathResolver' config must be a function.  Continuing ` +
           `with the agent's default behavior.`
diff --git a/src/debuggee.ts b/src/debuggee.ts
@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import is from '@sindresorhus/is';
-
 import {PackageInfo} from './client/stackdriver/debug';
 import {StatusMessage} from './client/stackdriver/status-message';
 
@@ -83,13 +81,13 @@ export class Debuggee {
 
     properties = properties || {};
 
-    if (!is.string(properties.project)) {
+    if (typeof properties.project !== 'string') {
       throw new Error('properties.project must be a string');
     }
-    if (!is.string(properties.uniquifier)) {
+    if (typeof properties.uniquifier !== 'string') {
       throw new Error('properties.uniquifier must be a string');
     }
-    if (!is.string(properties.description)) {
+    if (typeof properties.description !== 'string') {
       throw new Error('properties.description must be a string');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@`
`12`	`12`	`// See the License for the specific language governing permissions and`
`13`	`13`	`// limitations under the License.`
`14`	`14`
`15`		`-import is from '@sindresorhus/is';`
`16`	`15`	`import * as util from 'util';`
`17`	`16`	`import * as vm from 'vm';`
`18`	`17`
`@@ -366,7 +365,7 @@ class StateResolver {`
`366`	`365`	`// in locals which will include any applicable arguments from the`
`367`	`366`	`// invocation.`
`368`	`367`	`locals = this.resolveLocalsList_(frame);`
`369`		`- if (is.emptyArray(locals)) {`
	`368`	`+ if (Array.isArray(locals) && locals.length === 0) {`
`370`	`369`	`locals = [];`
`371`	`370`	`}`
`372`	`371`	`}`